]> source.dussan.org Git - vaadin-framework.git/commitdiff
Fix for #2043 - width/height for Link
authorArtur Signell <artur.signell@itmill.com>
Tue, 2 Sep 2008 13:12:54 +0000 (13:12 +0000)
committerArtur Signell <artur.signell@itmill.com>
Tue, 2 Sep 2008 13:12:54 +0000 (13:12 +0000)
svn changeset:5335/svn branch:trunk

src/com/itmill/toolkit/terminal/gwt/client/ui/ILink.java
src/com/itmill/toolkit/tests/tickets/Ticket2043.java [new file with mode: 0644]

index 37fa0038531bfc60bdb9bfbebed7a2ca1d63f736..4b9b86d1a36ee6e7d6209c61ada243fd83316dbd 100644 (file)
@@ -81,10 +81,10 @@ public class ILink extends HTML implements Paintable, ClickListener {
             borderStyle = BORDER_STYLE_DEFAULT;
         }
 
-        targetHeight = uidl.hasAttribute("height") ? uidl
+        targetHeight = uidl.hasAttribute("targetHeight") ? uidl
                 .getIntAttribute("targetHeight") : -1;
-        targetWidth = uidl.hasAttribute("width") ? uidl
-                .getIntAttribute("targetHeidth") : -1;
+        targetWidth = uidl.hasAttribute("targetWidth") ? uidl
+                .getIntAttribute("targetWidth") : -1;
 
         // Set link caption
         DOM.setInnerText(captionElement, uidl.getStringAttribute("caption"));
diff --git a/src/com/itmill/toolkit/tests/tickets/Ticket2043.java b/src/com/itmill/toolkit/tests/tickets/Ticket2043.java
new file mode 100644 (file)
index 0000000..ba2f00f
--- /dev/null
@@ -0,0 +1,27 @@
+package com.itmill.toolkit.tests.tickets;\r
+\r
+import com.itmill.toolkit.Application;\r
+import com.itmill.toolkit.terminal.ExternalResource;\r
+import com.itmill.toolkit.ui.GridLayout;\r
+import com.itmill.toolkit.ui.Link;\r
+import com.itmill.toolkit.ui.Window;\r
+\r
+public class Ticket2043 extends Application {\r
+\r
+    public void init() {\r
+        Window w = new Window(getClass().getSimpleName());\r
+        setMainWindow(w);\r
+        // setTheme("tests-tickets");\r
+        GridLayout layout = new GridLayout(10, 10);\r
+        w.setLayout(layout);\r
+        createUI(layout);\r
+    }\r
+\r
+    private void createUI(GridLayout layout) {\r
+        Link l = new Link("IT Mill home (new 200x200 window, no decor, icon)",\r
+                new ExternalResource("http://www.itmill.com"), "_blank", 200,\r
+                200, Link.TARGET_BORDER_NONE);\r
+\r
+        layout.addComponent(l);\r
+    }\r
+}\r