]> source.dussan.org Git - sonarqube.git/commitdiff
SONAR-11444 Issue comment form should not close automatically when selecting code
authorWouter Admiraal <wouter.admiraal@sonarsource.com>
Mon, 24 Dec 2018 13:02:18 +0000 (14:02 +0100)
committerSonarTech <sonartech@sonarsource.com>
Fri, 4 Jan 2019 19:21:02 +0000 (20:21 +0100)
server/sonar-web/src/main/js/components/issue/components/IssueCommentAction.tsx
server/sonar-web/src/main/js/components/issue/components/IssueCommentLine.tsx
server/sonar-web/src/main/js/components/issue/components/__tests__/__snapshots__/IssueCommentAction-test.tsx.snap
server/sonar-web/src/main/js/components/issue/components/__tests__/__snapshots__/IssueCommentLine-test.tsx.snap

index e7a971d18fe015bf2693db4d52522c91cb1cdabe..70ae7675aef11b5b4a3c2b6f663068762e468130 100644 (file)
@@ -51,6 +51,7 @@ export default class IssueCommentAction extends React.PureComponent<Props> {
     return (
       <li className="issue-meta dropdown">
         <Toggler
+          closeOnClickOutside={false}
           onRequestClose={this.handleClose}
           open={this.props.currentPopup === 'comment'}
           overlay={
index e6af6d1289bdb391766ac137972b13e9d7793cd8..66de33810724356bebb1be535556466deec137a5 100644 (file)
@@ -98,6 +98,7 @@ export default class IssueCommentLine extends React.PureComponent<Props, State>
           {comment.updatable && (
             <div className="dropdown">
               <Toggler
+                closeOnClickOutside={false}
                 onRequestClose={this.closePopups}
                 open={this.state.openPopup === 'edit'}
                 overlay={
index 1721de8d175f3eb74ad9457738d1cb0769a37aaf..0e6d7be6ca98c15740c42ed5f1485154eb6d3ce9 100644 (file)
@@ -5,6 +5,7 @@ exports[`should open the popup when the button is clicked 1`] = `
   className="issue-meta dropdown"
 >
   <Toggler
+    closeOnClickOutside={false}
     onRequestClose={[Function]}
     open={true}
     overlay={
@@ -46,6 +47,7 @@ exports[`should render correctly 1`] = `
   className="issue-meta dropdown"
 >
   <Toggler
+    closeOnClickOutside={false}
     onRequestClose={[Function]}
     open={false}
     overlay={
index b823f6b919d41e3f083fb2e32b28275f39772b93..2b347f6d7429a89c51db9c8a116f686188be32c3 100644 (file)
@@ -50,6 +50,7 @@ exports[`should open the right popups when the buttons are clicked 3`] = `
       className="dropdown"
     >
       <Toggler
+        closeOnClickOutside={false}
         onRequestClose={[Function]}
         open={false}
         overlay={
@@ -175,6 +176,7 @@ exports[`should render correctly a comment that is updatable 1`] = `
       className="dropdown"
     >
       <Toggler
+        closeOnClickOutside={false}
         onRequestClose={[Function]}
         open={false}
         overlay={