Remove "tabindex" from some form buttons (#27892)

Remove the "tabindex" from some form buttons on the "diff box" / "issue view content" page, let the browser use the default tab order.

---------

Co-authored-by: Gusted <postmaster@gusted.xyz>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

diff --git a/templates/repo/diff/box.tmpl b/templates/repo/diff/box.tmpl
index c037c3b365238454771f7a642a721bace74b7687..e00917746ead600dcfd59e4bbc517b4cb13482e7 100644 (file)
--- a/templates/repo/diff/box.tmpl
+++ b/templates/repo/diff/box.tmpl
@@ -238,8 +238,8 @@
                                        "DropzoneParentContainer" ".ui.form"
                                )}}
                                <div class="text right edit buttons">
-                                       <button class="ui cancel button" tabindex="3">{{ctx.Locale.Tr "repo.issues.cancel"}}</button>
-                                       <button class="ui primary save button" tabindex="2">{{ctx.Locale.Tr "repo.issues.save"}}</button>
+                                       <button class="ui cancel button">{{ctx.Locale.Tr "repo.issues.cancel"}}</button>
+                                       <button class="ui primary save button">{{ctx.Locale.Tr "repo.issues.save"}}</button>
                                </div>
                        </div>
                </template>

diff --git a/templates/repo/issue/view_content.tmpl b/templates/repo/issue/view_content.tmpl
index c17919f5bfb4291501beafd651229be4acd58957..9967997b92411347d522dc98e186d09be211e0da 100644 (file)
--- a/templates/repo/issue/view_content.tmpl
+++ b/templates/repo/issue/view_content.tmpl
@@ -92,7 +92,7 @@
                                                                <div class="text right">
                                                                        {{if and (or .HasIssuesOrPullsWritePermission .IsIssuePoster) (not .DisableStatusChange)}}
                                                                                {{if .Issue.IsClosed}}
-                                                                                       <button id="status-button" class="ui primary basic button" tabindex="6" data-status="{{ctx.Locale.Tr "repo.issues.reopen_issue"}}" data-status-and-comment="{{ctx.Locale.Tr "repo.issues.reopen_comment_issue"}}" name="status" value="reopen">
+                                                                                       <button id="status-button" class="ui primary basic button" data-status="{{ctx.Locale.Tr "repo.issues.reopen_issue"}}" data-status-and-comment="{{ctx.Locale.Tr "repo.issues.reopen_comment_issue"}}" name="status" value="reopen">
                                                                                                {{ctx.Locale.Tr "repo.issues.reopen_issue"}}
                                                                                        </button>
                                                                                {{else}}
@@ -100,12 +100,12 @@
                                                                                        {{if .Issue.IsPull}}
                                                                                                {{$closeTranslationKey = "repo.pulls.close"}}
                                                                                        {{end}}
-                                                                                       <button id="status-button" class="ui red basic button" tabindex="6" data-status="{{ctx.Locale.Tr $closeTranslationKey}}" data-status-and-comment="{{ctx.Locale.Tr "repo.issues.close_comment_issue"}}" name="status" value="close">
+                                                                                       <button id="status-button" class="ui red basic button" data-status="{{ctx.Locale.Tr $closeTranslationKey}}" data-status-and-comment="{{ctx.Locale.Tr "repo.issues.close_comment_issue"}}" name="status" value="close">
                                                                                                {{ctx.Locale.Tr $closeTranslationKey}}
                                                                                        </button>
                                                                                {{end}}
                                                                        {{end}}
-                                                                       <button class="ui primary button" tabindex="5">
+                                                                       <button class="ui primary button">
                                                                                {{ctx.Locale.Tr "repo.issues.create_comment"}}
                                                                        </button>
                                                                </div>
@@ -162,8 +162,8 @@
 
                <div class="field">
                        <div class="text right edit">
-                               <button class="ui basic cancel button" tabindex="3">{{ctx.Locale.Tr "repo.issues.cancel"}}</button>
-                               <button class="ui primary save button" tabindex="2">{{ctx.Locale.Tr "repo.issues.save"}}</button>
+                               <button class="ui basic cancel button">{{ctx.Locale.Tr "repo.issues.cancel"}}</button>
+                               <button class="ui primary save button">{{ctx.Locale.Tr "repo.issues.save"}}</button>
                        </div>
                </div>
        </div>