]> source.dussan.org Git - redmine.git/commitdiff
Raise MinSize for RuboCop Performance/CollectionLiteralInLoop to 4 (#38146).
authorGo MAEDA <maeda@farend.jp>
Wed, 11 Jan 2023 13:25:07 +0000 (13:25 +0000)
committerGo MAEDA <maeda@farend.jp>
Wed, 11 Jan 2023 13:25:07 +0000 (13:25 +0000)
git-svn-id: https://svn.redmine.org/redmine/trunk@22028 e93f8b46-1217-0410-a6f0-8f06a7374b81

.rubocop.yml
.rubocop_todo.yml

index d411d2a9a0ea8c00d668bc7eee3cf7daa77e50d9..3baa592f2e9acd074182259e491b7b285c02860a 100644 (file)
@@ -116,6 +116,9 @@ Naming/BinaryOperatorParameterName:
 Naming/PredicateName:
   Enabled: false
 
+Performance/CollectionLiteralInLoop:
+  MinSize: 4
+
 Rails/ActionControllerFlashBeforeRender:
   # False positive in actions where `redirect_to_referer_or` is used
   Enabled: false
index 2576c467bea0c759762ddb710555cbb075755014..2ed0864d475cc18c34f13d7d85798906c492c557 100644 (file)
@@ -486,26 +486,6 @@ Naming/VariableNumber:
     - 'test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb'
     - 'test/unit/project_test.rb'
 
-# Configuration parameters: MinSize.
-Performance/CollectionLiteralInLoop:
-  Exclude:
-    - 'app/helpers/imports_helper.rb'
-    - 'app/helpers/queries_helper.rb'
-    - 'app/helpers/settings_helper.rb'
-    - 'app/helpers/timelog_helper.rb'
-    - 'app/models/issue.rb'
-    - 'app/models/workflow_transition.rb'
-    - 'lib/redmine/helpers/time_report.rb'
-    - 'lib/redmine/scm/adapters/filesystem_adapter.rb'
-    - 'lib/redmine/wiki_formatting/textile/redcloth3.rb'
-    - 'test/functional/issues_custom_fields_visibility_test.rb'
-    - 'test/functional/repositories_git_controller_test.rb'
-    - 'test/functional/repositories_mercurial_controller_test.rb'
-    - 'test/functional/timelog_custom_fields_visibility_test.rb'
-    - 'test/unit/lib/redmine/scm/adapters/git_adapter_test.rb'
-    - 'test/unit/repository_git_test.rb'
-    - 'test/unit/repository_mercurial_test.rb'
-
 # This cop supports safe autocorrection (--autocorrect).
 Performance/ConstantRegexp:
   Exclude: