Strip whitespace from integer custom field (#8317).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17625 e93f8b46-1217-0410-a6f0-8f06a7374b81

diff --git a/lib/redmine/field_format.rb b/lib/redmine/field_format.rb
index 4d168b434bd6312813ba63258cb28502da506422..64fcdc6a4ea0aa8cdc0155078c153d61573c19be 100644 (file)
--- a/lib/redmine/field_format.rb
+++ b/lib/redmine/field_format.rb
@@ -490,7 +490,7 @@ module Redmine
 
       def validate_single_value(custom_field, value, customized=nil)
         errs = super
-        errs << ::I18n.t('activerecord.errors.messages.not_a_number') unless value.to_s =~ /^[+-]?\d+$/
+        errs << ::I18n.t('activerecord.errors.messages.not_a_number') unless value.to_s.strip =~ /^[+-]?\d+$/
         errs
       end
 

diff --git a/test/unit/custom_field_test.rb b/test/unit/custom_field_test.rb
index bdf5d48422b10565d8230e67fc896f26ca47365e..b1d7f7ad7ff8b2e070cb6e602e9d3a491453d6a0 100644 (file)
--- a/test/unit/custom_field_test.rb
+++ b/test/unit/custom_field_test.rb
@@ -206,6 +206,7 @@ class CustomFieldTest < ActiveSupport::TestCase
     assert f.valid_field_value?('')
     assert !f.valid_field_value?(' ')
     assert f.valid_field_value?('123')
+    assert f.valid_field_value?(' 123 ')
     assert f.valid_field_value?('+123')
     assert f.valid_field_value?('-123')
     assert !f.valid_field_value?('6abc')
@@ -219,6 +220,7 @@ class CustomFieldTest < ActiveSupport::TestCase
     assert f.valid_field_value?('')
     assert !f.valid_field_value?(' ')
     assert f.valid_field_value?('11.2')
+    assert f.valid_field_value?(' 11.2 ')
     assert f.valid_field_value?('-6.250')
     assert f.valid_field_value?('5')
     assert !f.valid_field_value?('6abc')