]> source.dussan.org Git - jquery-ui.git/commitdiff
Dialog: Coding standards.
authorScott González <scott.gonzalez@gmail.com>
Sat, 18 Dec 2010 00:53:22 +0000 (19:53 -0500)
committerScott González <scott.gonzalez@gmail.com>
Sat, 18 Dec 2010 00:53:22 +0000 (19:53 -0500)
ui/jquery.ui.dialog.js

index c4452368fb9a833a247a915ed67b157a7b582460..da57ae984331bc50007210da86a8fff7b0447629 100644 (file)
  */
 (function( $, undefined ) {
 
-var uiDialogClasses =
-               'ui-dialog ' +
-               'ui-widget ' +
-               'ui-widget-content ' +
-               'ui-corner-all ',
+var uiDialogClasses = "ui-dialog ui-widget ui-widget-content ui-corner-all ",
        sizeRelatedOptions = {
                buttons: true,
                height: true,
@@ -44,39 +40,39 @@ $.widget("ui.dialog", {
                autoOpen: true,
                buttons: {},
                closeOnEscape: true,
-               closeText: 'close',
-               dialogClass: '',
+               closeText: "close",
+               dialogClass: "",
                draggable: true,
                hide: null,
-               height: 'auto',
+               height: "auto",
                maxHeight: false,
                maxWidth: false,
                minHeight: 150,
                minWidth: 150,
                modal: false,
                position: {
-                       my: 'center',
-                       at: 'center',
+                       my: "center",
+                       at: "center",
                        of: window,
-                       collision: 'fit',
+                       collision: "fit",
                        // ensure that the titlebar is never outside the document
-                       using: function(pos) {
-                               var topOffset = $(this).css(pos).offset().top;
-                               if (topOffset < 0) {
-                                       $(this).css('top', pos.top - topOffset);
+                       using: function( pos ) {
+                               var topOffset = $( this ).css( pos ).offset().top;
+                               if ( topOffset < 0 ) {
+                                       $( this ).css( "top", pos.top - topOffset );
                                }
                        }
                },
                resizable: true,
                show: null,
                stack: true,
-               title: '',
+               title: "",
                width: 300,
                zIndex: 1000
        },
 
        _create: function() {
-               this.originalTitle = this.element.attr('title');
+               this.originalTitle = this.element.attr( "title" );
                // #5742 - .attr() might return a DOMElement
                if ( typeof this.originalTitle !== "string" ) {
                        this.originalTitle = "";
@@ -86,104 +82,93 @@ $.widget("ui.dialog", {
                var self = this,
                        options = self.options,
 
-                       title = options.title || '&#160;',
-                       titleId = $.ui.dialog.getTitleId(self.element),
+                       title = options.title || "&#160;",
+                       titleId = $.ui.dialog.getTitleId( self.element ),
 
-                       uiDialog = (self.uiDialog = $('<div></div>'))
-                               .appendTo(document.body)
+                       uiDialog = ( self.uiDialog = $( "<div>" ) )
+                               .appendTo( document.body )
                                .hide()
-                               .addClass(uiDialogClasses + options.dialogClass)
+                               .addClass( uiDialogClasses + options.dialogClass )
                                .css({
                                        zIndex: options.zIndex
                                })
                                // setting tabIndex makes the div focusable
-                               // setting outline to 0 prevents a border on focus in Mozilla
-                               .attr('tabIndex', -1).css('outline', 0).keydown(function(event) {
-                                       if (options.closeOnEscape && event.keyCode &&
-                                               event.keyCode === $.ui.keyCode.ESCAPE) {
-                                               
-                                               self.close(event);
+                               .attr( "tabIndex", -1)
+                               // TODO: move to stylesheet
+                               .css( "outline", 0 )
+                               .keydown(function( event ) {
+                                       if ( options.closeOnEscape && event.keyCode &&
+                                                       event.keyCode === $.ui.keyCode.ESCAPE ) {
+                                               self.close( event );
                                                event.preventDefault();
                                        }
                                })
                                .attr({
-                                       role: 'dialog',
-                                       'aria-labelledby': titleId
+                                       role: "dialog",
+                                       "aria-labelledby": titleId
                                })
-                               .mousedown(function(event) {
-                                       self.moveToTop(false, event);
+                               .mousedown(function( event ) {
+                                       self.moveToTop( false, event );
                                }),
 
                        uiDialogContent = self.element
                                .show()
-                               .removeAttr('title')
-                               .addClass(
-                                       'ui-dialog-content ' +
-                                       'ui-widget-content')
-                               .appendTo(uiDialog),
-
-                       uiDialogTitlebar = (self.uiDialogTitlebar = $('<div></div>'))
-                               .addClass(
-                                       'ui-dialog-titlebar ' +
-                                       'ui-widget-header ' +
-                                       'ui-corner-all ' +
-                                       'ui-helper-clearfix'
-                               )
-                               .prependTo(uiDialog),
-
-                       uiDialogTitlebarClose = $('<a href="#"></a>')
-                               .addClass(
-                                       'ui-dialog-titlebar-close ' +
-                                       'ui-corner-all'
-                               )
-                               .attr('role', 'button')
+                               .removeAttr( "title" )
+                               .addClass( "ui-dialog-content ui-widget-content" )
+                               .appendTo( uiDialog ),
+
+                       uiDialogTitlebar = ( self.uiDialogTitlebar = $( "<div>" ) )
+                               .addClass( "ui-dialog-titlebar  ui-widget-header  " +
+                                       "ui-corner-all  ui-helper-clearfix" )
+                               .prependTo( uiDialog ),
+
+                       uiDialogTitlebarClose = $( "<a href='#'>" )
+                               .addClass( "ui-dialog-titlebar-close  ui-corner-all" )
+                               .attr( "role", "button" )
                                .hover(
                                        function() {
-                                               uiDialogTitlebarClose.addClass('ui-state-hover');
+                                               uiDialogTitlebarClose.addClass( "ui-state-hover" );
                                        },
                                        function() {
-                                               uiDialogTitlebarClose.removeClass('ui-state-hover');
+                                               uiDialogTitlebarClose.removeClass( "ui-state-hover" );
                                        }
                                )
                                .focus(function() {
-                                       uiDialogTitlebarClose.addClass('ui-state-focus');
+                                       uiDialogTitlebarClose.addClass( "ui-state-focus" );
                                })
                                .blur(function() {
-                                       uiDialogTitlebarClose.removeClass('ui-state-focus');
+                                       uiDialogTitlebarClose.removeClass( "ui-state-focus" );
                                })
-                               .click(function(event) {
-                                       self.close(event);
+                               .click(function( event ) {
+                                       self.close( event );
                                        return false;
                                })
-                               .appendTo(uiDialogTitlebar),
+                               .appendTo( uiDialogTitlebar ),
 
-                       uiDialogTitlebarCloseText = (self.uiDialogTitlebarCloseText = $('<span></span>'))
-                               .addClass(
-                                       'ui-icon ' +
-                                       'ui-icon-closethick'
-                               )
-                               .text(options.closeText)
-                               .appendTo(uiDialogTitlebarClose),
+                       uiDialogTitlebarCloseText = ( self.uiDialogTitlebarCloseText = $( "<span>" ) )
+                               .addClass( "ui-icon ui-icon-closethick" )
+                               .text( options.closeText )
+                               .appendTo( uiDialogTitlebarClose ),
 
-                       uiDialogTitle = $('<span></span>')
-                               .addClass('ui-dialog-title')
-                               .attr('id', titleId)
-                               .html(title)
-                               .prependTo(uiDialogTitlebar);
+                       uiDialogTitle = $( "<span>" )
+                               .addClass( "ui-dialog-title" )
+                               .attr( "id", titleId )
+                               .html( title )
+                               .prependTo( uiDialogTitlebar );
 
-               uiDialogTitlebar.find("*").add(uiDialogTitlebar).disableSelection();
+               uiDialogTitlebar.find( "*" ).add( uiDialogTitlebar ).disableSelection();
 
-               if (options.draggable && $.fn.draggable) {
+               if ( options.draggable && $.fn.draggable ) {
                        self._makeDraggable();
                }
-               if (options.resizable && $.fn.resizable) {
+               if ( options.resizable && $.fn.resizable ) {
                        self._makeResizable();
                }
 
-               self._createButtons(options.buttons);
+               self._createButtons( options.buttons );
                self._isOpen = false;
 
-               if ($.fn.bgiframe) {
+               if ( $.fn.bgiframe ) {
                        uiDialog.bgiframe();
                }
        },
@@ -197,21 +182,21 @@ $.widget("ui.dialog", {
        destroy: function() {
                var self = this;
                
-               if (self.overlay) {
+               if ( self.overlay ) {
                        self.overlay.destroy();
                }
                self.uiDialog.hide();
                self.element
-                       .unbind('.dialog')
-                       .removeData('dialog')
-                       .removeClass('ui-dialog-content ui-widget-content')
-                       .hide().appendTo('body');
+                       .removeClass( "ui-dialog-content ui-widget-content" )
+                       .hide()
+                       .appendTo( "body" );
                self.uiDialog.remove();
 
-               if (self.originalTitle) {
-                       self.element.attr('title', self.originalTitle);
+               if ( self.originalTitle ) {
+                       self.element.attr( "title", self.originalTitle );
                }
 
+               $.Widget.prototype.destroy.call( this );
                return self;
        },
 
@@ -219,40 +204,40 @@ $.widget("ui.dialog", {
                return this.uiDialog;
        },
 
-       close: function(event) {
+       close: function( event ) {
                var self = this,
                        maxZ, thisZ;
                
-               if (false === self._trigger('beforeClose', event)) {
+               if ( false === self._trigger( "beforeClose", event ) ) {
                        return;
                }
 
-               if (self.overlay) {
+               if ( self.overlay ) {
                        self.overlay.destroy();
                }
-               self.uiDialog.unbind('keypress.ui-dialog');
+               self.uiDialog.unbind( "keypress.ui-dialog" );
 
                self._isOpen = false;
 
-               if (self.options.hide) {
-                       self.uiDialog.hide(self.options.hide, function() {
-                               self._trigger('close', event);
+               if ( self.options.hide ) {
+                       self.uiDialog.hide( self.options.hide, function() {
+                               self._trigger( "close", event );
                        });
                } else {
                        self.uiDialog.hide();
-                       self._trigger('close', event);
+                       self._trigger( "close", event );
                }
 
                $.ui.dialog.overlay.resize();
 
                // adjust the maxZ to allow other modal dialogs to continue to work (see #4309)
-               if (self.options.modal) {
+               if ( self.options.modal ) {
                        maxZ = 0;
-                       $('.ui-dialog').each(function() {
-                               if (this !== self.uiDialog[0]) {
-                                       thisZ = $(this).css('z-index');
-                                       if(!isNaN(thisZ)) {
-                                               maxZ = Math.max(maxZ, thisZ);
+                       $( ".ui-dialog" ).each(function() {
+                               if ( this !== self.uiDialog[0] ) {
+                                       thisZ = $( this ).css( "z-index" );
+                                       if ( !isNaN( thisZ ) ) {
+                                               maxZ = Math.max( maxZ, thisZ );
                                        }
                                }
                        });
@@ -268,64 +253,71 @@ $.widget("ui.dialog", {
 
        // the force parameter allows us to move modal dialogs to their correct
        // position on open
-       moveToTop: function(force, event) {
+       moveToTop: function( force, event ) {
                var self = this,
                        options = self.options,
                        saveScroll;
 
-               if ((options.modal && !force) ||
-                       (!options.stack && !options.modal)) {
-                       return self._trigger('focus', event);
+               if ( ( options.modal && !force ) ||
+                               ( !options.stack && !options.modal ) ) {
+                       return self._trigger( "focus", event );
                }
 
-               if (options.zIndex > $.ui.dialog.maxZ) {
+               if ( options.zIndex > $.ui.dialog.maxZ ) {
                        $.ui.dialog.maxZ = options.zIndex;
                }
-               if (self.overlay) {
+               if ( self.overlay ) {
                        $.ui.dialog.maxZ += 1;
-                       self.overlay.$el.css('z-index', $.ui.dialog.overlay.maxZ = $.ui.dialog.maxZ);
+                       $.ui.dialog.overlay.maxZ = $.ui.dialog.maxZ;
+                       self.overlay.$el.css( "z-index", $.ui.dialog.overlay.maxZ );
                }
 
-               //Save and then restore scroll since Opera 9.5+ resets when parent z-Index is changed.
-               //  http://ui.jquery.com/bugs/ticket/3193
-               saveScroll = { scrollTop: self.element.attr('scrollTop'), scrollLeft: self.element.attr('scrollLeft') };
+               // Save and then restore scroll
+               // Opera 9.5+ resets when parent z-index is changed.
+               // http://bugs.jqueryui.com/ticket/3193
+               saveScroll = {
+                       scrollTop: self.element.attr( "scrollTop" ),
+                       scrollLeft: self.element.attr( "scrollLeft" )
+               };
                $.ui.dialog.maxZ += 1;
-               self.uiDialog.css('z-index', $.ui.dialog.maxZ);
-               self.element.attr(saveScroll);
-               self._trigger('focus', event);
+               self.uiDialog.css( "z-index", $.ui.dialog.maxZ );
+               self.element.attr( saveScroll );
+               self._trigger( "focus", event );
 
                return self;
        },
 
        open: function() {
-               if (this._isOpen) { return; }
+               if ( this._isOpen ) {
+                       return;
+               }
 
                var self = this,
                        options = self.options,
                        uiDialog = self.uiDialog;
 
-               self.overlay = options.modal ? new $.ui.dialog.overlay(self) : null;
+               self.overlay = options.modal ? new $.ui.dialog.overlay( self ) : null;
                self._size();
-               self._position(options.position);
-               uiDialog.show(options.show);
-               self.moveToTop(true);
+               self._position( options.position );
+               uiDialog.show( options.show );
+               self.moveToTop( true );
 
                // prevent tabbing out of modal dialogs
-               if (options.modal) {
-                       uiDialog.bind('keypress.ui-dialog', function(event) {
-                               if (event.keyCode !== $.ui.keyCode.TAB) {
+               if ( options.modal ) {
+                       uiDialog.bind( "keypress.ui-dialog", function( event ) {
+                               if ( event.keyCode !== $.ui.keyCode.TAB ) {
                                        return;
                                }
 
-                               var tabbables = $(':tabbable', this),
-                                       first = tabbables.filter(':first'),
-                                       last  = tabbables.filter(':last');
+                               var tabbables = $( ":tabbable", this ),
+                                       first = tabbables.filter( ":first" ),
+                                       last  = tabbables.filter( ":last" );
 
-                               if (event.target === last[0] && !event.shiftKey) {
-                                       first.focus(1);
+                               if ( event.target === last[0] && !event.shiftKey ) {
+                                       first.focus( 1 );
                                        return false;
-                               } else if (event.target === first[0] && event.shiftKey) {
-                                       last.focus(1);
+                               } else if ( event.target === first[0] && event.shiftKey ) {
+                                       last.focus( 1 );
                                        return false;
                                }
                        });
@@ -333,64 +325,60 @@ $.widget("ui.dialog", {
 
                // set focus to the first tabbable element in the content area or the first button
                // if there are no tabbable elements, set focus on the dialog itself
-               $(self.element.find(':tabbable').get().concat(
-                       uiDialog.find('.ui-dialog-buttonpane :tabbable').get().concat(
-                               uiDialog.get()))).eq(0).focus();
+               $( self.element.find( ":tabbable" ).get().concat(
+                       uiDialog.find( ".ui-dialog-buttonpane :tabbable" ).get().concat(
+                               uiDialog.get() ) ) ).eq( 0 ).focus();
 
                self._isOpen = true;
-               self._trigger('open');
+               self._trigger( "open" );
 
                return self;
        },
 
-       _createButtons: function(buttons) {
+       _createButtons: function( buttons ) {
                var self = this,
                        hasButtons = false,
-                       uiDialogButtonPane = $('<div></div>')
-                               .addClass(
-                                       'ui-dialog-buttonpane ' +
-                                       'ui-widget-content ' +
-                                       'ui-helper-clearfix'
-                               ),
-                       uiButtonSet = $( "<div></div>" )
+                       uiDialogButtonPane = $( "<div>" )
+                               .addClass( "ui-dialog-buttonpane  ui-widget-content ui-helper-clearfix" ),
+                       uiButtonSet = $( "<div>" )
                                .addClass( "ui-dialog-buttonset" )
                                .appendTo( uiDialogButtonPane );
 
                // if we already have a button pane, remove it
-               self.uiDialog.find('.ui-dialog-buttonpane').remove();
+               self.uiDialog.find( ".ui-dialog-buttonpane" ).remove();
 
-               if (typeof buttons === 'object' && buttons !== null) {
-                       $.each(buttons, function() {
+               if ( typeof buttons === "object" && buttons !== null ) {
+                       $.each( buttons, function() {
                                return !(hasButtons = true);
                        });
                }
-               if (hasButtons) {
-                       $.each(buttons, function(name, props) {
+               if ( hasButtons ) {
+                       $.each( buttons, function( name, props ) {
                                props = $.isFunction( props ) ?
                                        { click: props, text: name } :
                                        props;
-                               var button = $('<button type="button"></button>')
+                               var button = $( "<button type='button'>" )
                                        .attr( props, true )
-                                       .unbind('click')
+                                       .unbind( "click" )
                                        .click(function() {
-                                               props.click.apply(self.element[0], arguments);
+                                               props.click.apply( self.element[0], arguments );
                                        })
-                                       .appendTo(uiButtonSet);
-                               if ($.fn.button) {
+                                       .appendTo( uiButtonSet );
+                               if ( $.fn.button ) {
                                        button.button();
                                }
                        });
-                       uiDialogButtonPane.appendTo(self.uiDialog);
+                       uiDialogButtonPane.appendTo( self.uiDialog );
                }
        },
 
        _makeDraggable: function() {
                var self = this,
                        options = self.options,
-                       doc = $(document),
+                       doc = $( document ),
                        heightBeforeDrag;
 
-               function filteredUi(ui) {
+               function filteredUi( ui ) {
                        return {
                                position: ui.position,
                                offset: ui.offset
@@ -398,40 +386,45 @@ $.widget("ui.dialog", {
                }
 
                self.uiDialog.draggable({
-                       cancel: '.ui-dialog-content, .ui-dialog-titlebar-close',
-                       handle: '.ui-dialog-titlebar',
-                       containment: 'document',
-                       start: function(event, ui) {
-                               heightBeforeDrag = options.height === "auto" ? "auto" : $(this).height();
-                               $(this).height($(this).height()).addClass("ui-dialog-dragging");
-                               self._trigger('dragStart', event, filteredUi(ui));
+                       cancel: ".ui-dialog-content, .ui-dialog-titlebar-close",
+                       handle: ".ui-dialog-titlebar",
+                       containment: "document",
+                       start: function( event, ui ) {
+                               heightBeforeDrag = options.height === "auto" ? "auto" : $( this ).height();
+                               $( this )
+                                       .height( $( this ).height() )
+                                       .addClass( "ui-dialog-dragging" );
+                               self._trigger( "dragStart", event, filteredUi( ui ) );
                        },
-                       drag: function(event, ui) {
-                               self._trigger('drag', event, filteredUi(ui));
+                       drag: function( event, ui ) {
+                               self._trigger( "drag", event, filteredUi( ui ) );
                        },
-                       stop: function(event, ui) {
-                               options.position = [ui.position.left - doc.scrollLeft(),
-                                       ui.position.top - doc.scrollTop()];
-                               $(this).removeClass("ui-dialog-dragging").height(heightBeforeDrag);
-                               self._trigger('dragStop', event, filteredUi(ui));
+                       stop: function( event, ui ) {
+                               options.position = [
+                                       ui.position.left - doc.scrollLeft(),
+                                       ui.position.top - doc.scrollTop()
+                               ];
+                               $( this )
+                                       .removeClass( "ui-dialog-dragging" )
+                                       .height( heightBeforeDrag );
+                               self._trigger( "dragStop", event, filteredUi( ui ) );
                                $.ui.dialog.overlay.resize();
                        }
                });
        },
 
-       _makeResizable: function(handles) {
+       _makeResizable: function( handles ) {
                handles = (handles === undefined ? this.options.resizable : handles);
                var self = this,
                        options = self.options,
                        // .ui-resizable has position: relative defined in the stylesheet
                        // but dialogs have to use absolute or fixed positioning
-                       position = self.uiDialog.css('position'),
-                       resizeHandles = (typeof handles === 'string' ?
+                       position = self.uiDialog.css( "position" ),
+                       resizeHandles = typeof handles === 'string' ?
                                handles :
-                               'n,e,s,w,se,sw,ne,nw'
-                       );
+                               "n,e,s,w,se,sw,ne,nw";
 
-               function filteredUi(ui) {
+               function filteredUi( ui ) {
                        return {
                                originalPosition: ui.originalPosition,
                                originalSize: ui.originalSize,
@@ -441,85 +434,86 @@ $.widget("ui.dialog", {
                }
 
                self.uiDialog.resizable({
-                       cancel: '.ui-dialog-content',
-                       containment: 'document',
+                       cancel: ".ui-dialog-content",
+                       containment: "document",
                        alsoResize: self.element,
                        maxWidth: options.maxWidth,
                        maxHeight: options.maxHeight,
                        minWidth: options.minWidth,
                        minHeight: self._minHeight(),
                        handles: resizeHandles,
-                       start: function(event, ui) {
-                               $(this).addClass("ui-dialog-resizing");
-                               self._trigger('resizeStart', event, filteredUi(ui));
+                       start: function( event, ui ) {
+                               $( this ).addClass( "ui-dialog-resizing" );
+                               self._trigger( "resizeStart", event, filteredUi( ui ) );
                        },
-                       resize: function(event, ui) {
-                               self._trigger('resize', event, filteredUi(ui));
+                       resize: function( event, ui ) {
+                               self._trigger( "resize", event, filteredUi( ui ) );
                        },
-                       stop: function(event, ui) {
-                               $(this).removeClass("ui-dialog-resizing");
-                               options.height = $(this).height();
-                               options.width = $(this).width();
-                               self._trigger('resizeStop', event, filteredUi(ui));
+                       stop: function( event, ui ) {
+                               $( this ).removeClass( "ui-dialog-resizing" );
+                               options.height = $( this ).height();
+                               options.width = $( this ).width();
+                               self._trigger( "resizeStop", event, filteredUi( ui ) );
                                $.ui.dialog.overlay.resize();
                        }
                })
-               .css('position', position)
-               .find('.ui-resizable-se').addClass('ui-icon ui-icon-grip-diagonal-se');
+               .css( "position", position )
+               .find( ".ui-resizable-se" )
+                       .addClass( "ui-icon ui-icon-grip-diagonal-se" );
        },
 
        _minHeight: function() {
                var options = this.options;
 
-               if (options.height === 'auto') {
+               if ( options.height === "auto" ) {
                        return options.minHeight;
                } else {
-                       return Math.min(options.minHeight, options.height);
+                       return Math.min( options.minHeight, options.height );
                }
        },
 
-       _position: function(position) {
+       _position: function( position ) {
                var myAt = [],
-                       offset = [0, 0],
+                       offset = [ 0, 0 ],
                        isVisible;
 
-               if (position) {
+               if ( position ) {
                        // deep extending converts arrays to objects in jQuery <= 1.3.2 :-(
        //              if (typeof position == 'string' || $.isArray(position)) {
        //                      myAt = $.isArray(position) ? position : position.split(' ');
 
-                       if (typeof position === 'string' || (typeof position === 'object' && '0' in position)) {
-                               myAt = position.split ? position.split(' ') : [position[0], position[1]];
-                               if (myAt.length === 1) {
-                                       myAt[1] = myAt[0];
+                       if ( typeof position === "string" || (typeof position === "object" && "0" in position ) ) {
+                               myAt = position.split ? position.split( " " ) : [ position[ 0 ], position[ 1 ] ];
+                               if ( myAt.length === 1 ) {
+                                       myAt[ 1 ] = myAt[ 0 ];
                                }
 
-                               $.each(['left', 'top'], function(i, offsetPosition) {
-                                       if (+myAt[i] === myAt[i]) {
-                                               offset[i] = myAt[i];
-                                               myAt[i] = offsetPosition;
+                               $.each( [ "left", "top" ], function( i, offsetPosition ) {
+                                       if ( +myAt[ i ] === myAt[ i ] ) {
+                                               offset[ i ] = myAt[ i ];
+                                               myAt[ i ] = offsetPosition;
                                        }
                                });
 
                                position = {
-                                       my: myAt.join(" "),
-                                       at: myAt.join(" "),
-                                       offset: offset.join(" ")
+                                       my: myAt.join( " " ),
+                                       at: myAt.join( " " ),
+                                       offset: offset.join( " " )
                                };
                        } 
 
-                       position = $.extend({}, $.ui.dialog.prototype.options.position, position);
+                       position = $.extend( {}, $.ui.dialog.prototype.options.position, position );
                } else {
                        position = $.ui.dialog.prototype.options.position;
                }
 
                // need to show the dialog to get the actual offset in the position plugin
-               isVisible = this.uiDialog.is(':visible');
-               if (!isVisible) {
+               isVisible = this.uiDialog.is( ":visible" );
+               if ( !isVisible ) {
                        this.uiDialog.show();
                }
-               this.uiDialog.position(position);
-               if (!isVisible) {
+               this.uiDialog.position( position );
+               if ( !isVisible ) {
                        this.uiDialog.hide();
                }
        },
@@ -548,28 +542,28 @@ $.widget("ui.dialog", {
                }
        },
 
-       _setOption: function(key, value){
+       _setOption: function( key, value ) {
                var self = this,
                        uiDialog = self.uiDialog;
 
-               switch (key) {
+               switch ( key ) {
                        case "buttons":
-                               self._createButtons(value);
+                               self._createButtons( value );
                                break;
                        case "closeText":
                                // ensure that we always pass a string
-                               self.uiDialogTitlebarCloseText.text("" + value);
+                               self.uiDialogTitlebarCloseText.text( "" + value );
                                break;
                        case "dialogClass":
                                uiDialog
-                                       .removeClass(self.options.dialogClass)
-                                       .addClass(uiDialogClasses + value);
+                                       .removeClass( self.options.dialogClass )
+                                       .addClass( uiDialogClasses + value );
                                break;
                        case "disabled":
-                               if (value) {
-                                       uiDialog.addClass('ui-dialog-disabled');
+                               if ( value ) {
+                                       uiDialog.addClass( "ui-dialog-disabled" );
                                } else {
-                                       uiDialog.removeClass('ui-dialog-disabled');
+                                       uiDialog.removeClass( "ui-dialog-disabled" );
                                }
                                break;
                        case "draggable":
@@ -583,32 +577,33 @@ $.widget("ui.dialog", {
                                }
                                break;
                        case "position":
-                               self._position(value);
+                               self._position( value );
                                break;
                        case "resizable":
                                // currently resizable, becoming non-resizable
                                var isResizable = uiDialog.is( ":data(resizable)" );
-                               if (isResizable && !value) {
-                                       uiDialog.resizable('destroy');
+                               if ( isResizable && !value ) {
+                                       uiDialog.resizable( "destroy" );
                                }
 
                                // currently resizable, changing handles
-                               if (isResizable && typeof value === 'string') {
-                                       uiDialog.resizable('option', 'handles', value);
+                               if ( isResizable && typeof value === "string" ) {
+                                       uiDialog.resizable( "option", "handles", value );
                                }
 
                                // currently non-resizable, becoming resizable
-                               if (!isResizable && value !== false) {
-                                       self._makeResizable(value);
+                               if ( !isResizable && value !== false ) {
+                                       self._makeResizable( value );
                                }
                                break;
                        case "title":
                                // convert whatever was passed in o a string, for html() to not throw up
-                               $(".ui-dialog-title", self.uiDialogTitlebar).html("" + (value || '&#160;'));
+                               $( ".ui-dialog-title", self.uiDialogTitlebar )
+                                       .html( "" + ( value || "&#160;" ) );
                                break;
                }
 
-               $.Widget.prototype._setOption.apply(self, arguments);
+               $.Widget.prototype._setOption.apply( self, arguments );
        },
 
        _size: function() {
@@ -622,19 +617,19 @@ $.widget("ui.dialog", {
 
                // reset content sizing
                this.element.show().css({
-                       width: 'auto',
+                       width: "auto",
                        minHeight: 0,
                        height: 0
                });
 
-               if (options.minWidth > options.width) {
+               if ( options.minWidth > options.width ) {
                        options.width = options.minWidth;
                }
 
                // reset wrapper sizing
                // determine the height of all the non-content elements
                nonContentHeight = this.uiDialog.css({
-                               height: 'auto',
+                               height: "auto",
                                width: options.width
                        })
                        .height();
@@ -659,8 +654,8 @@ $.widget("ui.dialog", {
                        this.element.height( Math.max( options.height - nonContentHeight, 0 ) );
                }
 
-               if (this.uiDialog.is(':data(resizable)')) {
-                       this.uiDialog.resizable('option', 'minHeight', this._minHeight());
+               if (this.uiDialog.is( ":data(resizable)" ) ) {
+                       this.uiDialog.resizable( "option", "minHeight", this._minHeight() );
                }
        }
 });
@@ -672,89 +667,93 @@ $.extend($.ui.dialog, {
        maxZ: 0,
 
        getTitleId: function($el) {
-               var id = $el.attr('id');
-               if (!id) {
+               var id = $el.attr( "id" );
+               if ( !id ) {
                        this.uuid += 1;
                        id = this.uuid;
                }
-               return 'ui-dialog-title-' + id;
+               return "ui-dialog-title-" + id;
        },
 
-       overlay: function(dialog) {
-               this.$el = $.ui.dialog.overlay.create(dialog);
+       overlay: function( dialog ) {
+               this.$el = $.ui.dialog.overlay.create( dialog );
        }
 });
 
-$.extend($.ui.dialog.overlay, {
+$.extend( $.ui.dialog.overlay, {
        instances: [],
        // reuse old instances due to IE memory leak with alpha transparency (see #5185)
        oldInstances: [],
        maxZ: 0,
-       events: $.map('focus,mousedown,mouseup,keydown,keypress,click'.split(','),
-               function(event) { return event + '.dialog-overlay'; }).join(' '),
-       create: function(dialog) {
-               if (this.instances.length === 0) {
+       events: $.map(
+               "focus,mousedown,mouseup,keydown,keypress,click".split( "," ),
+               function( event ) {
+                       return event + ".dialog-overlay";
+               }
+       ).join( " " ),
+       create: function( dialog ) {
+               if ( this.instances.length === 0 ) {
                        // prevent use of anchors and inputs
                        // we use a setTimeout in case the overlay is created from an
                        // event that we're going to be cancelling (see #2804)
                        setTimeout(function() {
                                // handle $(el).dialog().dialog('close') (see #4065)
-                               if ($.ui.dialog.overlay.instances.length) {
-                                       $(document).bind($.ui.dialog.overlay.events, function(event) {
+                               if ( $.ui.dialog.overlay.instances.length ) {
+                                       $( document ).bind( $.ui.dialog.overlay.events, function( event ) {
                                                // stop events if the z-index of the target is < the z-index of the overlay
                                                // we cannot return true when we don't want to cancel the event (#3523)
-                                               if ($(event.target).zIndex() < $.ui.dialog.overlay.maxZ) {
+                                               if ( $( event.target ).zIndex() < $.ui.dialog.overlay.maxZ ) {
                                                        return false;
                                                }
                                        });
                                }
-                       }, 1);
+                       }, 1 );
 
                        // allow closing by pressing the escape key
-                       $(document).bind('keydown.dialog-overlay', function(event) {
-                               if (dialog.options.closeOnEscape && event.keyCode &&
-                                       event.keyCode === $.ui.keyCode.ESCAPE) {
+                       $( document ).bind( "keydown.dialog-overlay", function( event ) {
+                               if ( dialog.options.closeOnEscape && event.keyCode &&
+                                       event.keyCode === $.ui.keyCode.ESCAPE ) {
                                        
-                                       dialog.close(event);
+                                       dialog.close( event );
                                        event.preventDefault();
                                }
                        });
 
                        // handle window resize
-                       $(window).bind('resize.dialog-overlay', $.ui.dialog.overlay.resize);
+                       $( window ).bind( "resize.dialog-overlay", $.ui.dialog.overlay.resize );
                }
 
-               var $el = (this.oldInstances.pop() || $('<div></div>').addClass('ui-widget-overlay'))
-                       .appendTo(document.body)
+               var $el = ( this.oldInstances.pop() || $( "<div>" ).addClass( "ui-widget-overlay" ) )
+                       .appendTo( document.body )
                        .css({
                                width: this.width(),
                                height: this.height()
                        });
 
-               if ($.fn.bgiframe) {
+               if ( $.fn.bgiframe ) {
                        $el.bgiframe();
                }
 
-               this.instances.push($el);
+               this.instances.push( $el );
                return $el;
        },
 
-       destroy: function($el) {
-               var indexOf = $.inArray($el, this.instances);
-               if (indexOf != -1){
-                       this.oldInstances.push(this.instances.splice(indexOf, 1)[0]);
+       destroy: function( $el ) {
+               var indexOf = $.inArray( $el, this.instances );
+               if ( indexOf !== -1 ) {
+                       this.oldInstances.push( this.instances.splice( indexOf, 1 )[ 0 ] );
                }
 
-               if (this.instances.length === 0) {
-                       $([document, window]).unbind('.dialog-overlay');
+               if ( this.instances.length === 0 ) {
+                       $( [ document, window ] ).unbind( ".dialog-overlay" );
                }
 
                $el.remove();
-               
+
                // adjust the maxZ to allow other modal dialogs to continue to work (see #4309)
                var maxZ = 0;
-               $.each(this.instances, function() {
-                       maxZ = Math.max(maxZ, this.css('z-index'));
+               $.each( this.instances, function() {
+                       maxZ = Math.max( maxZ, this.css( "z-index" ) );
                });
                this.maxZ = maxZ;
        },
@@ -763,7 +762,7 @@ $.extend($.ui.dialog.overlay, {
                var scrollHeight,
                        offsetHeight;
                // handle IE 6
-               if ($.browser.msie && $.browser.version < 7) {
+               if ( $.browser.msie && $.browser.version < 7 ) {
                        scrollHeight = Math.max(
                                document.documentElement.scrollHeight,
                                document.body.scrollHeight
@@ -773,14 +772,14 @@ $.extend($.ui.dialog.overlay, {
                                document.body.offsetHeight
                        );
 
-                       if (scrollHeight < offsetHeight) {
-                               return $(window).height() + 'px';
+                       if ( scrollHeight < offsetHeight ) {
+                               return $( window ).height() + "px";
                        } else {
-                               return scrollHeight + 'px';
+                               return scrollHeight + "px";
                        }
                // handle "good" browsers
                } else {
-                       return $(document).height() + 'px';
+                       return $( document ).height() + "px";
                }
        },
 
@@ -788,7 +787,7 @@ $.extend($.ui.dialog.overlay, {
                var scrollWidth,
                        offsetWidth;
                // handle IE 6
-               if ($.browser.msie && $.browser.version < 7) {
+               if ( $.browser.msie && $.browser.version < 7 ) {
                        scrollWidth = Math.max(
                                document.documentElement.scrollWidth,
                                document.body.scrollWidth
@@ -798,14 +797,14 @@ $.extend($.ui.dialog.overlay, {
                                document.body.offsetWidth
                        );
 
-                       if (scrollWidth < offsetWidth) {
-                               return $(window).width() + 'px';
+                       if ( scrollWidth < offsetWidth ) {
+                               return $( window ).width() + "px";
                        } else {
-                               return scrollWidth + 'px';
+                               return scrollWidth + "px";
                        }
                // handle "good" browsers
                } else {
-                       return $(document).width() + 'px';
+                       return $( document ).width() + "px";
                }
        },
 
@@ -818,9 +817,9 @@ $.extend($.ui.dialog.overlay, {
                 * This is handled by shrinking the overlay before setting it
                 * to the full document size.
                 */
-               var $overlays = $([]);
-               $.each($.ui.dialog.overlay.instances, function() {
-                       $overlays = $overlays.add(this);
+               var $overlays = $( [] );
+               $.each( $.ui.dialog.overlay.instances, function() {
+                       $overlays = $overlays.add( this );
                });
 
                $overlays.css({
@@ -833,10 +832,10 @@ $.extend($.ui.dialog.overlay, {
        }
 });
 
-$.extend($.ui.dialog.overlay.prototype, {
+$.extend( $.ui.dialog.overlay.prototype, {
        destroy: function() {
-               $.ui.dialog.overlay.destroy(this.$el);
+               $.ui.dialog.overlay.destroy( this.$el );
        }
 });
 
-}(jQuery));
+}( jQuery ) );