Apply some micro-optimization which helps when retrieving the string-value of large...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710692 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFRichTextString.java b/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFRichTextString.java
index 63f7a3ba8fd2c6fcda409e54e7b081aaecacd76e..70ad23655795c070acc4f1c0e3fcb6930e6aa914 100644 (file)
--- a/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFRichTextString.java
+++ b/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFRichTextString.java
@@ -315,7 +315,7 @@ public class XSSFRichTextString implements RichTextString {
         if(st.sizeOfRArray() == 0) {
             return utfDecode(st.getT());
         }
-        StringBuffer buf = new StringBuffer();
+        StringBuilder buf = new StringBuilder();
         for(CTRElt r : st.getRArray()){
             buf.append(r.getT());
         }
@@ -502,7 +502,7 @@ public class XSSFRichTextString implements RichTextString {
     static String utfDecode(String value){
         if(value == null) return null;
         
-        StringBuffer buf = new StringBuffer();
+        StringBuilder buf = new StringBuilder();
         Matcher m = utfPtrn.matcher(value);
         int idx = 0;
         while(m.find()) {
@@ -517,6 +517,13 @@ public class XSSFRichTextString implements RichTextString {
 
             idx = m.end();
         }
+        
+        // small optimization: don't go via StringBuilder if not necessary, 
+        // the encodings are very rare, so we should almost always go via this shortcut. 
+        if(idx == 0) {
+            return value;
+        }
+        
         buf.append(value.substring(idx));
         return buf.toString();
     }