Fix issues and spent time CSV export does not include custom fields with "Full width...

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@19632 e93f8b46-1217-0410-a6f0-8f06a7374b81

diff --git a/app/views/issues/index.html.erb b/app/views/issues/index.html.erb
index fccf118c94604b8dc88b1472a2cdcc3c852ece1f..c4719569dead2ffbc6d002ad50418ff6fcc56160 100644 (file)
--- a/app/views/issues/index.html.erb
+++ b/app/views/issues/index.html.erb
@@ -48,8 +48,9 @@
     <label><%= radio_button_tag 'c[]', 'all_inline' %> <%= l(:description_all_columns) %></label>
   </p>
   <p>
-    <label><%= check_box_tag 'c[]', 'description', @query.has_column?(:description) %> <%= l(:field_description) %></label>
-    <label><%= check_box_tag 'c[]', 'last_notes', @query.has_column?(:last_notes) %> <%= l(:label_last_notes) %></label>
+    <% @query.available_block_columns.each do |column| %>
+      <label><%= check_box_tag 'c[]', column.name, @query.has_column?(column) %> <%= column.caption %></label>
+    <% end %>
   </p>
   <%= export_csv_encoding_select_tag %>
   <% if @issue_count > Setting.issues_export_limit.to_i %>

diff --git a/app/views/timelog/index.html.erb b/app/views/timelog/index.html.erb
index b9afc7475deca7545dd1f1627bf542732a44bf37..f60b51064a2791a9148c6c6adf14ab32a559f248 100644 (file)
--- a/app/views/timelog/index.html.erb
+++ b/app/views/timelog/index.html.erb
@@ -40,6 +40,11 @@
     <label><%= radio_button_tag 'c[]', '', true %> <%= l(:description_selected_columns) %></label><br />
     <label><%= radio_button_tag 'c[]', 'all_inline' %> <%= l(:description_all_columns) %></label>
   </p>
+  <p>
+    <% @query.available_block_columns.each do |column| %>
+      <label><%= check_box_tag 'c[]', column.name, @query.has_column?(:column) %> <%= column.caption %></label>
+    <% end %>
+  </p>
   <%= export_csv_encoding_select_tag %>
   <p class="buttons">
     <%= submit_tag l(:button_export), :name => nil, :onclick => "hideModal(this);", :data => { :disable_with => false } %>

diff --git a/test/functional/issues_controller_test.rb b/test/functional/issues_controller_test.rb
index cb8a6703b3196e2fcbde954a1929d1220111909b..e27b3fdc9d28ef41a87cc8448cf1f850563c1187 100644 (file)
--- a/test/functional/issues_controller_test.rb
+++ b/test/functional/issues_controller_test.rb
@@ -777,6 +777,23 @@ class IssuesControllerTest < Redmine::ControllerTest
     assert_select '#csv-export-form input[name=?][value=?]', 'f[]', ''
   end
 
+  def test_index_should_show_block_columns_in_csv_export_form
+    field = IssueCustomField.
+              create!(
+                :name => 'Long text', :field_format => 'text',
+                :full_width_layout => '1',
+                :tracker_ids => [1], :is_for_all => true
+              )
+    get :index
+
+    assert_response :success
+    assert_select '#csv-export-form' do
+      assert_select 'input[value=?]', 'description'
+      assert_select 'input[value=?]', 'last_notes'
+      assert_select 'input[value=?]', "cf_#{field.id}"
+    end
+  end
+
   def test_index_csv
     get(:index, :params => {:format => 'csv'})
     assert_response :success