Correctly use groups parameter only when its not empty

Fix #9745

diff --git a/settings/ajax/createuser.php b/settings/ajax/createuser.php
index ae1d8856f43f833151110e7baebf8ff427a6ec1b..463c15d59e85d21c7ad72d6b53080bffde77a52a 100644 (file)
--- a/settings/ajax/createuser.php
+++ b/settings/ajax/createuser.php
@@ -5,21 +5,23 @@ OC_JSON::checkSubAdminUser();
 
 if(OC_User::isAdminUser(OC_User::getUser())) {
        $groups = array();
-       if( isset( $_POST["groups"] )) {
+       if (!empty($_POST["groups"])) {
                $groups = $_POST["groups"];
        }
 }else{
-       if(isset( $_POST["groups"] )) {
+       if (isset($_POST["groups"])) {
                $groups = array();
-               foreach($_POST["groups"] as $group) {
-                       if(OC_SubAdmin::isGroupAccessible(OC_User::getUser(), $group)) {
-                               $groups[] = $group;
+               if (!empty($_POST["groups"])) {
+                       foreach ($_POST["groups"] as $group) {
+                               if (OC_SubAdmin::isGroupAccessible(OC_User::getUser(), $group)) {
+                                       $groups[] = $group;
+                               }
                        }
                }
-               if(count($groups) === 0) {
+               if (empty($groups)) {
                        $groups = OC_SubAdmin::getSubAdminsGroups(OC_User::getUser());
                }
-       }else{
+       } else {
                $groups = OC_SubAdmin::getSubAdminsGroups(OC_User::getUser());
        }
 }