]> source.dussan.org Git - gitea.git/commitdiff
Prevent "Race" detected in TestAdmin*User (#16830)
authorzeripath <art27@cantab.net>
Fri, 27 Aug 2021 13:00:37 +0000 (14:00 +0100)
committerGitHub <noreply@github.com>
Fri, 27 Aug 2021 13:00:37 +0000 (15:00 +0200)
These tests are missing the defer prefix.

Related #1441

Signed-off-by: Andrew Thornton <art27@cantab.net>
integrations/admin_user_test.go

index f6b4590d27242b1384d8050dd73ae69bdc1c2fca..96233436e861a708b42f19d5f373b161b822cd06 100644 (file)
@@ -15,7 +15,7 @@ import (
 )
 
 func TestAdminViewUsers(t *testing.T) {
-       prepareTestEnv(t)
+       defer prepareTestEnv(t)()
 
        session := loginUser(t, "user1")
        req := NewRequest(t, "GET", "/admin/users")
@@ -27,7 +27,7 @@ func TestAdminViewUsers(t *testing.T) {
 }
 
 func TestAdminViewUser(t *testing.T) {
-       prepareTestEnv(t)
+       defer prepareTestEnv(t)()
 
        session := loginUser(t, "user1")
        req := NewRequest(t, "GET", "/admin/users/1")
@@ -39,7 +39,7 @@ func TestAdminViewUser(t *testing.T) {
 }
 
 func TestAdminEditUser(t *testing.T) {
-       prepareTestEnv(t)
+       defer prepareTestEnv(t)()
 
        testSuccessfullEdit(t, models.User{ID: 2, Name: "newusername", LoginName: "otherlogin", Email: "new@e-mail.gitea"})
 }