Fix database keyword quote problem on migration v161 (#17524)

* Fix database keyword quote problem on migration v161

* support rerun migration v161

diff --git a/models/migrations/v161.go b/models/migrations/v161.go
index 4ca9f01218725db1d84371df8f6c42b4f47558ea..283c44464c97a8b8867f2570ae1cad9bc0fe6d79 100644 (file)
--- a/models/migrations/v161.go
+++ b/models/migrations/v161.go
@@ -5,6 +5,8 @@
 package migrations
 
 import (
+       "context"
+
        "xorm.io/xorm"
 )
 
@@ -40,8 +42,17 @@ func convertTaskTypeToString(x *xorm.Engine) error {
                return err
        }
 
+       // to keep the migration could be rerun
+       exist, err := x.Dialect().IsColumnExist(x.DB(), context.Background(), "hook_task", "type")
+       if err != nil {
+               return err
+       }
+       if !exist {
+               return nil
+       }
+
        for i, s := range hookTaskTypes {
-               if _, err := x.Exec("UPDATE hook_task set typ = ? where type=?", s, i); err != nil {
+               if _, err := x.Exec("UPDATE hook_task set typ = ? where `type`=?", s, i); err != nil {
                        return err
                }
        }