]> source.dussan.org Git - sonarqube.git/commitdiff
Fix false-positive in unit test QualityGateActionTest
authorSimon Brandhof <simon.brandhof@sonarsource.com>
Fri, 20 Jul 2018 09:38:59 +0000 (11:38 +0200)
committerSonarTech <sonartech@sonarsource.com>
Sat, 21 Jul 2018 18:21:15 +0000 (20:21 +0200)
java.lang.AssertionError:
Expecting:
  <2018-07-20T00:12:15.000>
to be strictly before:
  <2018-07-20T00:12:15.000>
at org.sonar.server.badge.ws.QualityGateActionTest.checkError(QualityGateActionTest.java:347)
at org.sonar.server.badge.ws.QualityGateActionTest.return_error_on_private_project(QualityGateActionTest.java:242)

server/sonar-server/src/test/java/org/sonar/server/badge/ws/QualityGateActionTest.java

index 39b0b9e54cfc29dfeb329ff69996eb45000adb97..dce53cb085afeac9b1d3cd021bbc9d707822c172 100644 (file)
@@ -344,7 +344,7 @@ public class QualityGateActionTest {
     assertThat(response.getHeader("Cache-Control")).contains("no-cache");
     assertThat(response.getHeader("Expires")).isNotNull();
     assertThat(response.getHeader("ETag")).isNull();
-    assertThat(expiresDateFormat.parse(response.getHeader("Expires"))).isBefore(new Date());
+    assertThat(expiresDateFormat.parse(response.getHeader("Expires"))).isBeforeOrEqualsTo(new Date());
     assertThat(response.getInput()).contains("<text", ">" + expectedError + "</text>");
   }