Fix Internal Error when issue text custom field is shown in Spent time query results...

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@19419 e93f8b46-1217-0410-a6f0-8f06a7374b81

diff --git a/app/views/timelog/_list.html.erb b/app/views/timelog/_list.html.erb
index b3146c28bea7b65eae8a651c14a9366a62b60725..582d1208cd2e50d964dcdb9b67762ad81c85dab4 100644 (file)
--- a/app/views/timelog/_list.html.erb
+++ b/app/views/timelog/_list.html.erb
@@ -50,11 +50,12 @@
         <%= link_to_context_menu %>
     </td>
   </tr>
+
   <% @query.block_columns.each do |column|
-       if (text = column_content(column, issue)) && text.present? -%>
+       if (text = column_content(column, entry)) && text.present? -%>
   <tr class="<%= current_cycle %>">
     <td colspan="<%= @query.inline_columns.size + 1 %>" class="<%= column.css_classes %>">
-    <% if query.block_columns.count > 1 %>
+    <% if @query.block_columns.count > 1 %>
       <span><%= column.caption %></span>
     <% end %>
     <%= text %>

diff --git a/test/functional/timelog_controller_test.rb b/test/functional/timelog_controller_test.rb
index 6046b1cd1aec56d04f9655f1a8497a65917459c4..6c69f6f9f2160e95413ca1674a7897e09b9f4469 100644 (file)
--- a/test/functional/timelog_controller_test.rb
+++ b/test/functional/timelog_controller_test.rb
@@ -1430,4 +1430,19 @@ class TimelogControllerTest < Redmine::ControllerTest
       assert_select '+ span.count', :text => '2'
     end
   end
+
+  def test_index_with_inline_issue_long_text_custom_field_column
+    field = IssueCustomField.create!(:name => 'Long text', :field_format => 'text', :full_width_layout => '1',
+      :tracker_ids => [1], :is_for_all => true)
+    issue = Issue.find(1)
+    issue.custom_field_values = {field.id => 'This is a long text'}
+    issue.save!
+
+    get :index, :params => {
+        :set_filter => 1,
+        :c => ['subject', 'description', "issue.cf_#{field.id}"]
+      }
+    assert_response :success
+    assert_select "td.issue_cf_#{field.id}", :text => 'This is a long text'
+  end
 end