Fix some quality flaws

diff --git a/sonar-deprecated/src/main/java/org/sonar/api/batch/AbstractDirectoriesDecorator.java b/sonar-deprecated/src/main/java/org/sonar/api/batch/AbstractDirectoriesDecorator.java
index 3ccc4edae819c7bbd55f88add28cd204ee7c138e..cf54bafecdf5ef358d1362fdb796bb66b8cc261c 100644 (file)
--- a/sonar-deprecated/src/main/java/org/sonar/api/batch/AbstractDirectoriesDecorator.java
+++ b/sonar-deprecated/src/main/java/org/sonar/api/batch/AbstractDirectoriesDecorator.java
@@ -36,7 +36,7 @@ public abstract class AbstractDirectoriesDecorator implements Decorator {
   /**
    * @param language this will be use to defined whether the decorator should be executed on a project
    */
-  public AbstractDirectoriesDecorator(Language language) {//NOSONAR this unused parameter is kept for backward-compatibility of API
+  public AbstractDirectoriesDecorator(Language language) {
   }
 
   /**

diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/batch/rule/internal/DefaultRule.java b/sonar-plugin-api/src/main/java/org/sonar/api/batch/rule/internal/DefaultRule.java
index ba3580b20933f08ee33cb156e3e51ca035071aea..784425b5d2a2fea1a5645f9425e862c6bf28fba8 100644 (file)
--- a/sonar-plugin-api/src/main/java/org/sonar/api/batch/rule/internal/DefaultRule.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/batch/rule/internal/DefaultRule.java
@@ -34,7 +34,7 @@ import java.util.Map;
 public class DefaultRule implements Rule {
 
   private final RuleKey key;
-  private Integer id;
+  private final Integer id;
   private final String name, severity, description, metadata;
   private final RuleStatus status;
   private final Map<String, RuleParam> params;

diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/rule/RuleStatus.java b/sonar-plugin-api/src/main/java/org/sonar/api/rule/RuleStatus.java
index 00b97edcd0269fdf59c0c582282b3e2af26ab8db..d9d95535cebdbba97c3a676ca5fb3f346ba661f5 100644 (file)
--- a/sonar-plugin-api/src/main/java/org/sonar/api/rule/RuleStatus.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/rule/RuleStatus.java
@@ -28,4 +28,4 @@ public enum RuleStatus {
   public static RuleStatus defaultStatus() {
     return READY;
   }
-}
\ No newline at end of file
+}

diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/rules/ActiveRule.java b/sonar-plugin-api/src/main/java/org/sonar/api/rules/ActiveRule.java
index 5c21e31b7888a8ad9f32567c33325ef4bf1db10a..55772eac07d95c5366dbc16ec69d4fb6a4445872 100644 (file)
--- a/sonar-plugin-api/src/main/java/org/sonar/api/rules/ActiveRule.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/rules/ActiveRule.java
@@ -36,7 +36,6 @@ import java.util.List;
  */
 @Entity
 @Table(name = "active_rules")
-@Deprecated
 public class ActiveRule implements Cloneable {
 
   public static final String INHERITED = "INHERITED";