fix: Prevent breaking change in IQueryBuilder

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

diff --git a/apps/federatedfilesharing/lib/FederatedShareProvider.php b/apps/federatedfilesharing/lib/FederatedShareProvider.php
index 45ac8ba15def542339daf1267d5c7776f0c42a92..c115c6133385736dbc9443499b578fcad85d81ef 100644 (file)
--- a/apps/federatedfilesharing/lib/FederatedShareProvider.php
+++ b/apps/federatedfilesharing/lib/FederatedShareProvider.php
@@ -303,7 +303,7 @@ class FederatedShareProvider implements IShareProvider {
                        ->setValue('uid_owner', $qb->createNamedParameter($uidOwner))
                        ->setValue('uid_initiator', $qb->createNamedParameter($sharedBy))
                        ->setValue('permissions', $qb->createNamedParameter($permissions))
-                       ->setValue('expiration', $qb->createNamedParameter($expirationDate, IQueryBuilder::PARAM_DATETIME))
+                       ->setValue('expiration', $qb->createNamedParameter($expirationDate, IQueryBuilder::PARAM_DATETIME_MUTABLE))
                        ->setValue('token', $qb->createNamedParameter($token))
                        ->setValue('stime', $qb->createNamedParameter(time()));
 
@@ -333,7 +333,7 @@ class FederatedShareProvider implements IShareProvider {
                        ->set('permissions', $qb->createNamedParameter($share->getPermissions()))
                        ->set('uid_owner', $qb->createNamedParameter($share->getShareOwner()))
                        ->set('uid_initiator', $qb->createNamedParameter($share->getSharedBy()))
-                       ->set('expiration', $qb->createNamedParameter($share->getExpirationDate(), IQueryBuilder::PARAM_DATETIME))
+                       ->set('expiration', $qb->createNamedParameter($share->getExpirationDate(), IQueryBuilder::PARAM_DATETIME_MUTABLE))
                        ->executeStatement();
 
                // send the updated permission to the owner/initiator, if they are not the same

diff --git a/apps/files_reminders/lib/Db/ReminderMapper.php b/apps/files_reminders/lib/Db/ReminderMapper.php
index 35421656da2b4727bb20055aa6106ebd6061a6a6..e747c8af397f92b67566cb2d66a9d361109242c3 100644 (file)
--- a/apps/files_reminders/lib/Db/ReminderMapper.php
+++ b/apps/files_reminders/lib/Db/ReminderMapper.php
@@ -135,7 +135,7 @@ class ReminderMapper extends QBMapper {
                $qb->select('id', 'user_id', 'file_id', 'due_date', 'updated_at', 'created_at', 'notified')
                        ->from($this->getTableName())
                        ->where($qb->expr()->eq('notified', $qb->createNamedParameter(true, IQueryBuilder::PARAM_BOOL)))
-                       ->andWhere($qb->expr()->lt('due_date', $qb->createNamedParameter($buffer, IQueryBuilder::PARAM_DATETIME)))
+                       ->andWhere($qb->expr()->lt('due_date', $qb->createNamedParameter($buffer, IQueryBuilder::PARAM_DATETIME_MUTABLE)))
                        ->orderBy('due_date', 'ASC')
                        ->setMaxResults($limit);
 

diff --git a/apps/sharebymail/lib/ShareByMailProvider.php b/apps/sharebymail/lib/ShareByMailProvider.php
index 77ff33cdbeb3ca6323c5ba4cedc5d8dbeb58da34..9efc0ec2513a8430b4ddb66adede99231e1d76a1 100644 (file)
--- a/apps/sharebymail/lib/ShareByMailProvider.php
+++ b/apps/sharebymail/lib/ShareByMailProvider.php
@@ -699,7 +699,7 @@ class ShareByMailProvider extends DefaultShareProvider implements IShareProvider
                        ->setValue('permissions', $qb->createNamedParameter($permissions))
                        ->setValue('token', $qb->createNamedParameter($token))
                        ->setValue('password', $qb->createNamedParameter($password))
-                       ->setValue('password_expiration_time', $qb->createNamedParameter($passwordExpirationTime, IQueryBuilder::PARAM_DATETIME))
+                       ->setValue('password_expiration_time', $qb->createNamedParameter($passwordExpirationTime, IQueryBuilder::PARAM_DATETIME_MUTABLE))
                        ->setValue('password_by_talk', $qb->createNamedParameter($sendPasswordByTalk, IQueryBuilder::PARAM_BOOL))
                        ->setValue('stime', $qb->createNamedParameter(time()))
                        ->setValue('hide_download', $qb->createNamedParameter((int)$hideDownload, IQueryBuilder::PARAM_INT))
@@ -712,7 +712,7 @@ class ShareByMailProvider extends DefaultShareProvider implements IShareProvider
 
                $qb->setValue('attributes', $qb->createNamedParameter($shareAttributes));
                if ($expirationTime !== null) {
-                       $qb->setValue('expiration', $qb->createNamedParameter($expirationTime, IQueryBuilder::PARAM_DATETIME));
+                       $qb->setValue('expiration', $qb->createNamedParameter($expirationTime, IQueryBuilder::PARAM_DATETIME_MUTABLE));
                }
 
                $qb->executeStatement();
@@ -752,10 +752,10 @@ class ShareByMailProvider extends DefaultShareProvider implements IShareProvider
                        ->set('uid_owner', $qb->createNamedParameter($share->getShareOwner()))
                        ->set('uid_initiator', $qb->createNamedParameter($share->getSharedBy()))
                        ->set('password', $qb->createNamedParameter($share->getPassword()))
-                       ->set('password_expiration_time', $qb->createNamedParameter($share->getPasswordExpirationTime(), IQueryBuilder::PARAM_DATETIME))
+                       ->set('password_expiration_time', $qb->createNamedParameter($share->getPasswordExpirationTime(), IQueryBuilder::PARAM_DATETIME_MUTABLE))
                        ->set('label', $qb->createNamedParameter($share->getLabel()))
                        ->set('password_by_talk', $qb->createNamedParameter($share->getSendPasswordByTalk(), IQueryBuilder::PARAM_BOOL))
-                       ->set('expiration', $qb->createNamedParameter($share->getExpirationDate(), IQueryBuilder::PARAM_DATETIME))
+                       ->set('expiration', $qb->createNamedParameter($share->getExpirationDate(), IQueryBuilder::PARAM_DATETIME_MUTABLE))
                        ->set('note', $qb->createNamedParameter($share->getNote()))
                        ->set('hide_download', $qb->createNamedParameter((int)$share->getHideDownload(), IQueryBuilder::PARAM_INT))
                        ->set('attributes', $qb->createNamedParameter($shareAttributes))

diff --git a/lib/private/Comments/Manager.php b/lib/private/Comments/Manager.php
index 860d3034ce8f8f1de9a4c96e41194fe9fe44fa77..d959ebcb0a31cc63174676882179b0ee126f342e 100644 (file)
--- a/lib/private/Comments/Manager.php
+++ b/lib/private/Comments/Manager.php
@@ -440,14 +440,14 @@ class Manager implements ICommentsManager {
                                        $query->expr()->orX(
                                                $query->expr()->lt(
                                                        'creation_timestamp',
-                                                       $query->createNamedParameter($lastKnownCommentDateTime, IQueryBuilder::PARAM_DATETIME),
-                                                       IQueryBuilder::PARAM_DATETIME
+                                                       $query->createNamedParameter($lastKnownCommentDateTime, IQueryBuilder::PARAM_DATETIME_MUTABLE),
+                                                       IQueryBuilder::PARAM_DATETIME_MUTABLE
                                                ),
                                                $query->expr()->andX(
                                                        $query->expr()->eq(
                                                                'creation_timestamp',
-                                                               $query->createNamedParameter($lastKnownCommentDateTime, IQueryBuilder::PARAM_DATETIME),
-                                                               IQueryBuilder::PARAM_DATETIME
+                                                               $query->createNamedParameter($lastKnownCommentDateTime, IQueryBuilder::PARAM_DATETIME_MUTABLE),
+                                                               IQueryBuilder::PARAM_DATETIME_MUTABLE
                                                        ),
                                                        $idComparison
                                                )
@@ -463,14 +463,14 @@ class Manager implements ICommentsManager {
                                        $query->expr()->orX(
                                                $query->expr()->gt(
                                                        'creation_timestamp',
-                                                       $query->createNamedParameter($lastKnownCommentDateTime, IQueryBuilder::PARAM_DATETIME),
-                                                       IQueryBuilder::PARAM_DATETIME
+                                                       $query->createNamedParameter($lastKnownCommentDateTime, IQueryBuilder::PARAM_DATETIME_MUTABLE),
+                                                       IQueryBuilder::PARAM_DATETIME_MUTABLE
                                                ),
                                                $query->expr()->andX(
                                                        $query->expr()->eq(
                                                                'creation_timestamp',
-                                                               $query->createNamedParameter($lastKnownCommentDateTime, IQueryBuilder::PARAM_DATETIME),
-                                                               IQueryBuilder::PARAM_DATETIME
+                                                               $query->createNamedParameter($lastKnownCommentDateTime, IQueryBuilder::PARAM_DATETIME_MUTABLE),
+                                                               IQueryBuilder::PARAM_DATETIME_MUTABLE
                                                        ),
                                                        $idComparison
                                                )
@@ -740,7 +740,7 @@ class Manager implements ICommentsManager {
                        ->from('comments')
                        ->where($query->expr()->eq('object_type', $query->createNamedParameter($objectType)))
                        ->andWhere($query->expr()->eq('object_id', $query->createNamedParameter($objectId)))
-                       ->andWhere($query->expr()->lt('creation_timestamp', $query->createNamedParameter($beforeDate, IQueryBuilder::PARAM_DATETIME)))
+                       ->andWhere($query->expr()->lt('creation_timestamp', $query->createNamedParameter($beforeDate, IQueryBuilder::PARAM_DATETIME_MUTABLE)))
                        ->orderBy('creation_timestamp', 'desc');
 
                if ($verb !== '') {
@@ -1551,7 +1551,7 @@ class Manager implements ICommentsManager {
                $qb = $this->dbConn->getQueryBuilder();
                $qb->delete('comments')
                        ->where($qb->expr()->lte('expire_date',
-                               $qb->createNamedParameter($this->timeFactory->getDateTime(), IQueryBuilder::PARAM_DATETIME)))
+                               $qb->createNamedParameter($this->timeFactory->getDateTime(), IQueryBuilder::PARAM_DATETIME_MUTABLE)))
                        ->andWhere($qb->expr()->eq('object_type', $qb->createNamedParameter($objectType)));
 
                if ($objectId !== '') {

diff --git a/lib/private/DB/QueryBuilder/ExpressionBuilder/SqliteExpressionBuilder.php b/lib/private/DB/QueryBuilder/ExpressionBuilder/SqliteExpressionBuilder.php
index d1ca65b0bdac9c94773ceb84467c64adf8da496b..559c29df208766648472d96b794268fc73522026 100644 (file)
--- a/lib/private/DB/QueryBuilder/ExpressionBuilder/SqliteExpressionBuilder.php
+++ b/lib/private/DB/QueryBuilder/ExpressionBuilder/SqliteExpressionBuilder.php
@@ -49,17 +49,17 @@ class SqliteExpressionBuilder extends ExpressionBuilder {
         */
        public function castColumn($column, $type): IQueryFunction {
                switch ($type) {
-                       case IQueryBuilder::PARAM_DATE:
+                       case IQueryBuilder::PARAM_DATE_MUTABLE:
                        case IQueryBuilder::PARAM_DATE_IMMUTABLE:
                                $column = $this->helper->quoteColumnName($column);
                                return new QueryFunction('DATE(' . $column . ')');
-                       case IQueryBuilder::PARAM_DATETIME:
-                       case IQueryBuilder::PARAM_DATETIME_TZ:
+                       case IQueryBuilder::PARAM_DATETIME_MUTABLE:
                        case IQueryBuilder::PARAM_DATETIME_IMMUTABLE:
+                       case IQueryBuilder::PARAM_DATETIME_TZ_MUTABLE:
                        case IQueryBuilder::PARAM_DATETIME_TZ_IMMUTABLE:
                                $column = $this->helper->quoteColumnName($column);
                                return new QueryFunction('DATETIME(' . $column . ')');
-                       case IQueryBuilder::PARAM_TIME:
+                       case IQueryBuilder::PARAM_TIME_MUTABLE:
                        case IQueryBuilder::PARAM_TIME_IMMUTABLE:
                                $column = $this->helper->quoteColumnName($column);
                                return new QueryFunction('TIME(' . $column . ')');

diff --git a/lib/private/Security/RateLimiting/Backend/DatabaseBackend.php b/lib/private/Security/RateLimiting/Backend/DatabaseBackend.php
index b03f5f3d29513d58b42516493131ca089ae7b619..9fb237f2f720a1048b542889fd789a785562a29f 100644 (file)
--- a/lib/private/Security/RateLimiting/Backend/DatabaseBackend.php
+++ b/lib/private/Security/RateLimiting/Backend/DatabaseBackend.php
@@ -42,7 +42,7 @@ class DatabaseBackend implements IBackend {
                $qb = $this->dbConnection->getQueryBuilder();
                $qb->delete(self::TABLE_NAME)
                        ->where(
-                               $qb->expr()->lte('delete_after', $qb->createNamedParameter($currentTime, IQueryBuilder::PARAM_DATETIME))
+                               $qb->expr()->lte('delete_after', $qb->createNamedParameter($currentTime, IQueryBuilder::PARAM_DATETIME_MUTABLE))
                        )
                        ->executeStatement();
 
@@ -87,7 +87,7 @@ class DatabaseBackend implements IBackend {
                $qb->insert(self::TABLE_NAME)
                        ->values([
                                'hash' => $qb->createNamedParameter($identifier, IQueryBuilder::PARAM_STR),
-                               'delete_after' => $qb->createNamedParameter($deleteAfter, IQueryBuilder::PARAM_DATETIME),
+                               'delete_after' => $qb->createNamedParameter($deleteAfter, IQueryBuilder::PARAM_DATETIME_MUTABLE),
                        ]);
 
                if (!$this->config->getSystemValueBool('ratelimit.protection.enabled', true)) {

diff --git a/lib/private/Share20/DefaultShareProvider.php b/lib/private/Share20/DefaultShareProvider.php
index 9c36860cb4577c76628061d5010eaa0de7941c9f..77251fd0bc168fc918309b8a9f4465e3b5cc6bf6 100644 (file)
--- a/lib/private/Share20/DefaultShareProvider.php
+++ b/lib/private/Share20/DefaultShareProvider.php
@@ -222,7 +222,7 @@ class DefaultShareProvider implements IShareProviderWithNotification, IShareProv
                                ->set('attributes', $qb->createNamedParameter($shareAttributes))
                                ->set('item_source', $qb->createNamedParameter($share->getNode()->getId()))
                                ->set('file_source', $qb->createNamedParameter($share->getNode()->getId()))
-                               ->set('expiration', $qb->createNamedParameter($expirationDate, IQueryBuilder::PARAM_DATETIME))
+                               ->set('expiration', $qb->createNamedParameter($expirationDate, IQueryBuilder::PARAM_DATETIME_MUTABLE))
                                ->set('note', $qb->createNamedParameter($share->getNote()))
                                ->set('accepted', $qb->createNamedParameter($share->getStatus()))
                                ->set('reminder_sent', $qb->createNamedParameter($share->getReminderSent(), IQueryBuilder::PARAM_BOOL))
@@ -237,7 +237,7 @@ class DefaultShareProvider implements IShareProviderWithNotification, IShareProv
                                ->set('attributes', $qb->createNamedParameter($shareAttributes))
                                ->set('item_source', $qb->createNamedParameter($share->getNode()->getId()))
                                ->set('file_source', $qb->createNamedParameter($share->getNode()->getId()))
-                               ->set('expiration', $qb->createNamedParameter($expirationDate, IQueryBuilder::PARAM_DATETIME))
+                               ->set('expiration', $qb->createNamedParameter($expirationDate, IQueryBuilder::PARAM_DATETIME_MUTABLE))
                                ->set('note', $qb->createNamedParameter($share->getNote()))
                                ->execute();
 
@@ -252,7 +252,7 @@ class DefaultShareProvider implements IShareProviderWithNotification, IShareProv
                                ->set('uid_initiator', $qb->createNamedParameter($share->getSharedBy()))
                                ->set('item_source', $qb->createNamedParameter($share->getNode()->getId()))
                                ->set('file_source', $qb->createNamedParameter($share->getNode()->getId()))
-                               ->set('expiration', $qb->createNamedParameter($expirationDate, IQueryBuilder::PARAM_DATETIME))
+                               ->set('expiration', $qb->createNamedParameter($expirationDate, IQueryBuilder::PARAM_DATETIME_MUTABLE))
                                ->set('note', $qb->createNamedParameter($share->getNote()))
                                ->execute();
 
@@ -279,7 +279,7 @@ class DefaultShareProvider implements IShareProviderWithNotification, IShareProv
                                ->set('item_source', $qb->createNamedParameter($share->getNode()->getId()))
                                ->set('file_source', $qb->createNamedParameter($share->getNode()->getId()))
                                ->set('token', $qb->createNamedParameter($share->getToken()))
-                               ->set('expiration', $qb->createNamedParameter($expirationDate, IQueryBuilder::PARAM_DATETIME))
+                               ->set('expiration', $qb->createNamedParameter($expirationDate, IQueryBuilder::PARAM_DATETIME_MUTABLE))
                                ->set('note', $qb->createNamedParameter($share->getNote()))
                                ->set('label', $qb->createNamedParameter($share->getLabel()))
                                ->set('hide_download', $qb->createNamedParameter($share->getHideDownload() ? 1 : 0), IQueryBuilder::PARAM_INT)

diff --git a/lib/private/TextToImage/Db/TaskMapper.php b/lib/private/TextToImage/Db/TaskMapper.php
index 3d1e2c249a4eea0250124572e1374dec0b66b08a..37f492e14cf3bfedbc598d7b7656e9f9e8a47b9d 100644 (file)
--- a/lib/private/TextToImage/Db/TaskMapper.php
+++ b/lib/private/TextToImage/Db/TaskMapper.php
@@ -95,11 +95,11 @@ class TaskMapper extends QBMapper {
                $qb = $this->db->getQueryBuilder();
                $qb->select('*')
                        ->from($this->tableName)
-                       ->where($qb->expr()->lt('last_updated', $qb->createPositionalParameter($datetime, IQueryBuilder::PARAM_DATETIME)));
+                       ->where($qb->expr()->lt('last_updated', $qb->createPositionalParameter($datetime, IQueryBuilder::PARAM_DATETIME_MUTABLE)));
                $deletedTasks = $this->findEntities($qb);
                $qb = $this->db->getQueryBuilder();
                $qb->delete($this->tableName)
-                       ->where($qb->expr()->lt('last_updated', $qb->createPositionalParameter($datetime, IQueryBuilder::PARAM_DATETIME)));
+                       ->where($qb->expr()->lt('last_updated', $qb->createPositionalParameter($datetime, IQueryBuilder::PARAM_DATETIME_MUTABLE)));
                $qb->executeStatement();
                return $deletedTasks;
        }

diff --git a/lib/public/AppFramework/Db/QBMapper.php b/lib/public/AppFramework/Db/QBMapper.php
index c0667d2711183b6eac34dee335335684ef569e0d..243310fe93301793e30a300686140172ca6be91b 100644 (file)
--- a/lib/public/AppFramework/Db/QBMapper.php
+++ b/lib/public/AppFramework/Db/QBMapper.php
@@ -230,11 +230,11 @@ abstract class QBMapper {
                        case Types::BLOB:
                                return IQueryBuilder::PARAM_LOB;
                        case Types::DATE:
-                               return IQueryBuilder::PARAM_DATE;
+                               return IQueryBuilder::PARAM_DATETIME_MUTABLE;
                        case Types::DATETIME:
-                               return IQueryBuilder::PARAM_DATETIME;
+                               return IQueryBuilder::PARAM_DATETIME_MUTABLE;
                        case Types::DATETIME_TZ:
-                               return IQueryBuilder::PARAM_DATETIME_TZ;
+                               return IQueryBuilder::PARAM_DATETIME_TZ_MUTABLE;
                        case Types::DATE_IMMUTABLE:
                                return IQueryBuilder::PARAM_DATE_IMMUTABLE;
                        case Types::DATETIME_IMMUTABLE:
@@ -242,7 +242,7 @@ abstract class QBMapper {
                        case Types::DATETIME_TZ_IMMUTABLE:
                                return IQueryBuilder::PARAM_DATETIME_TZ_IMMUTABLE;
                        case Types::TIME:
-                               return IQueryBuilder::PARAM_TIME;
+                               return IQueryBuilder::PARAM_TIME_MUTABLE;
                        case Types::TIME_IMMUTABLE:
                                return IQueryBuilder::PARAM_TIME_IMMUTABLE;
                        case Types::JSON:

diff --git a/lib/public/DB/QueryBuilder/IQueryBuilder.php b/lib/public/DB/QueryBuilder/IQueryBuilder.php
index 1ff2d4959c54462861750a36c63404783d9bb5cf..4794e7e88777548ebe9a28a8b3111b3eb465b936 100644 (file)
--- a/lib/public/DB/QueryBuilder/IQueryBuilder.php
+++ b/lib/public/DB/QueryBuilder/IQueryBuilder.php
@@ -43,29 +43,35 @@ interface IQueryBuilder {
         */
        public const PARAM_LOB = ParameterType::LARGE_OBJECT;
 
+       /**
+        * @since 9.0.0
+        * @deprecated 31.0.0 - use PARAM_DATETIME_MUTABLE instead
+        */
+       public const PARAM_DATE = Types::DATETIME_MUTABLE;
+
        /**
         * For passing a \DateTime instance when only interested in the time part (without timezone support)
         * @since 31.0.0
         */
-       public const PARAM_TIME = Types::TIME_MUTABLE;
+       public const PARAM_TIME_MUTABLE = Types::TIME_MUTABLE;
 
        /**
         * For passing a \DateTime instance when only interested in the date part (without timezone support)
-        * @since 9.0.0
+        * @since 31.0.0
         */
-       public const PARAM_DATE = Types::DATE_MUTABLE;
+       public const PARAM_DATE_MUTABLE = Types::DATE_MUTABLE;
 
        /**
         * For passing a \DateTime instance (without timezone support)
         * @since 31.0.0
         */
-       public const PARAM_DATETIME = Types::DATETIME_MUTABLE;
+       public const PARAM_DATETIME_MUTABLE = Types::DATETIME_MUTABLE;
 
        /**
         * For passing a \DateTime instance with timezone support
         * @since 31.0.0
         */
-       public const PARAM_DATETIME_TZ = Types::DATETIMETZ_MUTABLE;
+       public const PARAM_DATETIME_TZ_MUTABLE = Types::DATETIMETZ_MUTABLE;
 
        /**
         * For passing a \DateTimeImmutable instance when only interested in the time part (without timezone support)

diff --git a/tests/lib/AppFramework/Db/QBMapperTest.php b/tests/lib/AppFramework/Db/QBMapperTest.php
index 5fb46bfd668daa0599954ccd97df50e3f437c312..3cf32e56f125c3046a7c772a6c16ea9df9870b81 100644 (file)
--- a/tests/lib/AppFramework/Db/QBMapperTest.php
+++ b/tests/lib/AppFramework/Db/QBMapperTest.php
@@ -151,7 +151,7 @@ class QBMapperTest extends \Test\TestCase {
                $entity->setStringProp('string');
                $entity->setIntegerProp(456);
                $entity->setBooleanProp(false);
-               $entity->setJsonProp(["hello" => "world"]);
+               $entity->setJsonProp(['hello' => 'world']);
                $entity->setDatetimeProp($datetime);
 
                $idParam = $this->qb->createNamedParameter('id', IQueryBuilder::PARAM_INT);
@@ -171,7 +171,7 @@ class QBMapperTest extends \Test\TestCase {
                                [$this->equalTo('string'), $this->equalTo(IQueryBuilder::PARAM_STR)],
                                [$this->equalTo(456), $this->equalTo(IQueryBuilder::PARAM_INT)],
                                [$this->equalTo(false), $this->equalTo(IQueryBuilder::PARAM_BOOL)],
-                               [$this->equalTo(["hello" => "world"]), $this->equalTo(IQueryBuilder::PARAM_JSON)],
+                               [$this->equalTo(['hello' => 'world']), $this->equalTo(IQueryBuilder::PARAM_JSON)],
                                [$this->equalTo($datetime), $this->equalTo(IQueryBuilder::PARAM_DATETIME_IMMUTABLE)],
                                [$this->equalTo(789), $this->equalTo(IQueryBuilder::PARAM_INT)],
                        );

diff --git a/tests/lib/Comments/ManagerTest.php b/tests/lib/Comments/ManagerTest.php
index 44cb7c36f3194c11fe29648544141987cafcc46f..15961b029f520ab8779eded70c245829f778c889 100644 (file)
--- a/tests/lib/Comments/ManagerTest.php
+++ b/tests/lib/Comments/ManagerTest.php
@@ -71,11 +71,11 @@ class ManagerTest extends TestCase {
                                'actor_id' => $qb->createNamedParameter('alice'),
                                'message' => $qb->createNamedParameter('nice one'),
                                'verb' => $qb->createNamedParameter('comment'),
-                               'creation_timestamp' => $qb->createNamedParameter($creationDT, IQueryBuilder::PARAM_DATETIME),
-                               'latest_child_timestamp' => $qb->createNamedParameter($latestChildDT, IQueryBuilder::PARAM_DATETIME),
+                               'creation_timestamp' => $qb->createNamedParameter($creationDT, IQueryBuilder::PARAM_DATETIME_MUTABLE),
+                               'latest_child_timestamp' => $qb->createNamedParameter($latestChildDT, IQueryBuilder::PARAM_DATETIME_MUTABLE),
                                'object_type' => $qb->createNamedParameter('files'),
                                'object_id' => $qb->createNamedParameter($objectId),
-                               'expire_date' => $qb->createNamedParameter($expireDate, IQueryBuilder::PARAM_DATETIME),
+                               'expire_date' => $qb->createNamedParameter($expireDate, IQueryBuilder::PARAM_DATETIME_MUTABLE),
                                'reference_id' => $qb->createNamedParameter('referenceId'),
                                'meta_data' => $qb->createNamedParameter(json_encode(['last_edit_actor_id' => 'admin'])),
                        ])

diff --git a/tests/lib/DB/QueryBuilder/ExpressionBuilderDBTest.php b/tests/lib/DB/QueryBuilder/ExpressionBuilderDBTest.php
index 536e9f38405e5146a21fc819cdb23f854e648288..392fe9ff9374a76df8727da85c91cc719a0211a0 100644 (file)
--- a/tests/lib/DB/QueryBuilder/ExpressionBuilderDBTest.php
+++ b/tests/lib/DB/QueryBuilder/ExpressionBuilderDBTest.php
@@ -145,13 +145,13 @@ class ExpressionBuilderDBTest extends TestCase {
                $dateTime = new \DateTime('2023-01-01');
                $insert = $this->connection->getQueryBuilder();
                $insert->insert('testing')
-                       ->values(['datetime' => $insert->createNamedParameter($dateTime, IQueryBuilder::PARAM_DATE)])
+                       ->values(['datetime' => $insert->createNamedParameter($dateTime, IQueryBuilder::PARAM_DATETIME_MUTABLE)])
                        ->executeStatement();
 
                $query = $this->connection->getQueryBuilder();
                $result = $query->select('*')
                        ->from('testing')
-                       ->where($query->expr()->eq('datetime', $query->createNamedParameter($dateTime, IQueryBuilder::PARAM_DATE)))
+                       ->where($query->expr()->eq('datetime', $query->createNamedParameter($dateTime, IQueryBuilder::PARAM_DATETIME_MUTABLE)))
                        ->executeQuery();
                $entries = $result->fetchAll();
                $result->closeCursor();
@@ -163,13 +163,13 @@ class ExpressionBuilderDBTest extends TestCase {
                $dateTimeCompare = new \DateTime('2022-01-02');
                $insert = $this->connection->getQueryBuilder();
                $insert->insert('testing')
-                       ->values(['datetime' => $insert->createNamedParameter($dateTime, IQueryBuilder::PARAM_DATE)])
+                       ->values(['datetime' => $insert->createNamedParameter($dateTime, IQueryBuilder::PARAM_DATETIME_MUTABLE)])
                        ->executeStatement();
 
                $query = $this->connection->getQueryBuilder();
                $result = $query->select('*')
                        ->from('testing')
-                       ->where($query->expr()->lt('datetime', $query->createNamedParameter($dateTimeCompare, IQueryBuilder::PARAM_DATE)))
+                       ->where($query->expr()->lt('datetime', $query->createNamedParameter($dateTimeCompare, IQueryBuilder::PARAM_DATETIME_MUTABLE)))
                        ->executeQuery();
                $entries = $result->fetchAll();
                $result->closeCursor();
@@ -181,13 +181,13 @@ class ExpressionBuilderDBTest extends TestCase {
                $dateTimeCompare = new \DateTime('2023-01-01');
                $insert = $this->connection->getQueryBuilder();
                $insert->insert('testing')
-                       ->values(['datetime' => $insert->createNamedParameter($dateTime, IQueryBuilder::PARAM_DATE)])
+                       ->values(['datetime' => $insert->createNamedParameter($dateTime, IQueryBuilder::PARAM_DATETIME_MUTABLE)])
                        ->executeStatement();
 
                $query = $this->connection->getQueryBuilder();
                $result = $query->select('*')
                        ->from('testing')
-                       ->where($query->expr()->gt('datetime', $query->createNamedParameter($dateTimeCompare, IQueryBuilder::PARAM_DATE)))
+                       ->where($query->expr()->gt('datetime', $query->createNamedParameter($dateTimeCompare, IQueryBuilder::PARAM_DATETIME_MUTABLE)))
                        ->executeQuery();
                $entries = $result->fetchAll();
                $result->closeCursor();

diff --git a/tests/lib/Share20/DefaultShareProviderTest.php b/tests/lib/Share20/DefaultShareProviderTest.php
index 5effaea8cf91aaa334687c885316beb4ac1d35f9..0351504e1a7cb7ae6ee437a5ffff0ab8120df2b7 100644 (file)
--- a/tests/lib/Share20/DefaultShareProviderTest.php
+++ b/tests/lib/Share20/DefaultShareProviderTest.php
@@ -162,7 +162,7 @@ class DefaultShareProviderTest extends \Test\TestCase {
                        $qb->setValue('token', $qb->expr()->literal($token));
                }
                if ($expiration) {
-                       $qb->setValue('expiration', $qb->createNamedParameter($expiration, IQueryBuilder::PARAM_DATE));
+                       $qb->setValue('expiration', $qb->createNamedParameter($expiration, IQueryBuilder::PARAM_DATETIME_MUTABLE));
                }
                if ($parent) {
                        $qb->setValue('parent', $qb->expr()->literal($parent));

diff --git a/tests/lib/Share20/ShareByMailProviderTest.php b/tests/lib/Share20/ShareByMailProviderTest.php
index 01029e421e090e3b4ec1fd2da76f03140ec3bc68..bc8e9e53df0916abe2eb13de085b8248b644793c 100644 (file)
--- a/tests/lib/Share20/ShareByMailProviderTest.php
+++ b/tests/lib/Share20/ShareByMailProviderTest.php
@@ -179,7 +179,7 @@ class ShareByMailProviderTest extends TestCase {
                        $qb->setValue('token', $qb->expr()->literal($token));
                }
                if ($expiration) {
-                       $qb->setValue('expiration', $qb->createNamedParameter($expiration, IQueryBuilder::PARAM_DATE));
+                       $qb->setValue('expiration', $qb->createNamedParameter($expiration, IQueryBuilder::PARAM_DATETIME_MUTABLE));
                }
                if ($parent) {
                        $qb->setValue('parent', $qb->expr()->literal($parent));