]> source.dussan.org Git - sonarqube.git/commitdiff
SONAR-16975 [894133] Visual heading text is not marked as heading
authorWouter Admiraal <wouter.admiraal@sonarsource.com>
Fri, 7 Oct 2022 09:22:15 +0000 (11:22 +0200)
committersonartech <sonartech@sonarsource.com>
Tue, 11 Oct 2022 20:03:59 +0000 (20:03 +0000)
server/sonar-web/src/main/js/apps/projectActivity/components/ProjectActivityAnalysesList.tsx
server/sonar-web/src/main/js/apps/projectActivity/components/__tests__/__snapshots__/ProjectActivityAnalysesList-test.tsx.snap
server/sonar-web/src/main/js/apps/projectActivity/components/projectActivity.css

index 8e99aee8cea9282f490c296b53063b7b94e03ccd..3a6966eecc3e8205e272fe7f352321fadff669ac 100644 (file)
@@ -199,7 +199,7 @@ export default class ProjectActivityAnalysesList extends React.PureComponent<Pro
                   <Tooltip
                     mouseEnterDelay={0.5}
                     overlay={`${translate('version')} ${version.version}`}>
-                    <span className="analysis-version">{version.version}</span>
+                    <h2 className="analysis-version">{version.version}</h2>
                   </Tooltip>
                 </div>
               )}
@@ -209,9 +209,9 @@ export default class ProjectActivityAnalysesList extends React.PureComponent<Pro
                     className="project-activity-day"
                     data-day={toShortNotSoISOString(Number(day))}
                     key={day}>
-                    <div className="project-activity-date">
+                    <h3>
                       <DateFormatter date={Number(day)} long={true} />
-                    </div>
+                    </h3>
                     <ul className="project-activity-analyses-list">
                       {version.byDay[day] != null &&
                         version.byDay[day].map(analysis => this.renderAnalysis(analysis))}
index 1f18e89399fa8c33f9f96ad83391384211831fb2..7298b91e0d774d8db9ff16d745e0a311613ef3b5 100644 (file)
@@ -20,11 +20,11 @@ exports[`should correctly filter analyses by category 1`] = `
         mouseEnterDelay={0.5}
         overlay="version 6.4"
       >
-        <span
+        <h2
           className="analysis-version"
         >
           6.4
-        </span>
+        </h2>
       </Tooltip>
     </div>
     <ul
@@ -35,14 +35,12 @@ exports[`should correctly filter analyses by category 1`] = `
         data-day="ISO.1477267200000"
         key="1477267200000"
       >
-        <div
-          className="project-activity-date"
-        >
+        <h3>
           <DateFormatter
             date={1477267200000}
             long={true}
           />
-        </div>
+        </h3>
         <ul
           className="project-activity-analyses-list"
         >
@@ -101,11 +99,11 @@ exports[`should correctly filter analyses by date range 1`] = `
         mouseEnterDelay={0.5}
         overlay="version 6.5-SNAPSHOT"
       >
-        <span
+        <h2
           className="analysis-version"
         >
           6.5-SNAPSHOT
-        </span>
+        </h2>
       </Tooltip>
     </div>
     <ul
@@ -116,14 +114,12 @@ exports[`should correctly filter analyses by date range 1`] = `
         data-day="ISO.1477526400000"
         key="1477526400000"
       >
-        <div
-          className="project-activity-date"
-        >
+        <h3>
           <DateFormatter
             date={1477526400000}
             long={true}
           />
-        </div>
+        </h3>
         <ul
           className="project-activity-analyses-list"
         >
@@ -182,11 +178,11 @@ exports[`should render correctly: application 1`] = `
         mouseEnterDelay={0.5}
         overlay="version 6.5-SNAPSHOT"
       >
-        <span
+        <h2
           className="analysis-version"
         >
           6.5-SNAPSHOT
-        </span>
+        </h2>
       </Tooltip>
     </div>
     <ul
@@ -197,14 +193,12 @@ exports[`should render correctly: application 1`] = `
         data-day="ISO.1477526400000"
         key="1477526400000"
       >
-        <div
-          className="project-activity-date"
-        >
+        <h3>
           <DateFormatter
             date={1477526400000}
             long={true}
           />
-        </div>
+        </h3>
         <ul
           className="project-activity-analyses-list"
         >
@@ -272,11 +266,11 @@ exports[`should render correctly: application 1`] = `
         mouseEnterDelay={0.5}
         overlay="version 6.4"
       >
-        <span
+        <h2
           className="analysis-version"
         >
           6.4
-        </span>
+        </h2>
       </Tooltip>
     </div>
     <ul
@@ -287,14 +281,12 @@ exports[`should render correctly: application 1`] = `
         data-day="ISO.1477440000000"
         key="1477440000000"
       >
-        <div
-          className="project-activity-date"
-        >
+        <h3>
           <DateFormatter
             date={1477440000000}
             long={true}
           />
-        </div>
+        </h3>
         <ul
           className="project-activity-analyses-list"
         >
@@ -338,14 +330,12 @@ exports[`should render correctly: application 1`] = `
         data-day="ISO.1477267200000"
         key="1477267200000"
       >
-        <div
-          className="project-activity-date"
-        >
+        <h3>
           <DateFormatter
             date={1477267200000}
             long={true}
           />
-        </div>
+        </h3>
         <ul
           className="project-activity-analyses-list"
         >
@@ -404,11 +394,11 @@ exports[`should render correctly: default 1`] = `
         mouseEnterDelay={0.5}
         overlay="version 6.5-SNAPSHOT"
       >
-        <span
+        <h2
           className="analysis-version"
         >
           6.5-SNAPSHOT
-        </span>
+        </h2>
       </Tooltip>
     </div>
     <ul
@@ -419,14 +409,12 @@ exports[`should render correctly: default 1`] = `
         data-day="ISO.1477526400000"
         key="1477526400000"
       >
-        <div
-          className="project-activity-date"
-        >
+        <h3>
           <DateFormatter
             date={1477526400000}
             long={true}
           />
-        </div>
+        </h3>
         <ul
           className="project-activity-analyses-list"
         >
@@ -494,11 +482,11 @@ exports[`should render correctly: default 1`] = `
         mouseEnterDelay={0.5}
         overlay="version 6.4"
       >
-        <span
+        <h2
           className="analysis-version"
         >
           6.4
-        </span>
+        </h2>
       </Tooltip>
     </div>
     <ul
@@ -509,14 +497,12 @@ exports[`should render correctly: default 1`] = `
         data-day="ISO.1477440000000"
         key="1477440000000"
       >
-        <div
-          className="project-activity-date"
-        >
+        <h3>
           <DateFormatter
             date={1477440000000}
             long={true}
           />
-        </div>
+        </h3>
         <ul
           className="project-activity-analyses-list"
         >
@@ -560,14 +546,12 @@ exports[`should render correctly: default 1`] = `
         data-day="ISO.1477267200000"
         key="1477267200000"
       >
-        <div
-          className="project-activity-date"
-        >
+        <h3>
           <DateFormatter
             date={1477267200000}
             long={true}
           />
-        </div>
+        </h3>
         <ul
           className="project-activity-analyses-list"
         >
index c9dd45e14c6099c00677bd659d0a0873780ade02..2f4f0f9d65af4220944f34a771cffa89c41be6e5 100644 (file)
   margin-bottom: 10px;
 }
 
-.project-activity-date {
-  margin-bottom: calc(2 * var(--gridSize));
-  font-size: var(--bigFontSize);
-  font-weight: bold;
-}
-
 .project-activity-analysis {
   position: relative;
   min-height: var(--smallControlHeight);