LfsConnectionFactory#getLfsUrl: Fix unconditional break in for-loop

When iterating over the remote URLs to find one that matches "origin",
it always exits after the first iteration whether it has found the
remote or not. The break should be inside the conditional block so
that it exits when "origin" is found, otherwise continues to iterate
over the remaining remote URLs.

Found by Sonar Lint.

Change-Id: Ic969e54071d1cf095334007c1c1bab6579044dd2
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>

diff --git a/org.eclipse.jgit.lfs/src/org/eclipse/jgit/lfs/internal/LfsConnectionFactory.java b/org.eclipse.jgit.lfs/src/org/eclipse/jgit/lfs/internal/LfsConnectionFactory.java
index cbad1b66a970ed031cd3a5077a1e21e7d4239db0..7a0ed456c1b3e7df4759ffc049ffe9c988d7940d 100644 (file)
--- a/org.eclipse.jgit.lfs/src/org/eclipse/jgit/lfs/internal/LfsConnectionFactory.java
+++ b/org.eclipse.jgit.lfs/src/org/eclipse/jgit/lfs/internal/LfsConnectionFactory.java
@@ -112,8 +112,8 @@ public class LfsConnectionFactory {
                                        remoteUrl = config.getString(
                                                        ConfigConstants.CONFIG_KEY_REMOTE, remote,
                                                        ConfigConstants.CONFIG_KEY_URL);
+                                       break;
                                }
-                               break;
                        }
                        if (lfsUrl == null && remoteUrl != null) {
                                try {