Add message for DoesNotExistException

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

diff --git a/lib/private/Updater/ChangesCheck.php b/lib/private/Updater/ChangesCheck.php
index 575a9ceadaf34d4c86e25c686ac8aed2822a518e..a47eb7d5f0875747d441759929e66aecd75098de 100644 (file)
--- a/lib/private/Updater/ChangesCheck.php
+++ b/lib/private/Updater/ChangesCheck.php
@@ -54,8 +54,8 @@ class ChangesCheck {
                $version = $this->normalizeVersion($version);
                $changesInfo = $this->mapper->getChanges($version);
                $changesData = json_decode($changesInfo->getData(), true);
-               if(empty($changesData)) {
-                       throw new DoesNotExistException();
+               if (empty($changesData)) {
+                       throw new DoesNotExistException('Unable to decode changes info');
                }
                return $changesData;
        }

diff --git a/tests/lib/Updater/ChangesCheckTest.php b/tests/lib/Updater/ChangesCheckTest.php
index 2b1954ee48f2312b16987f04c8f09b5b1c24827d..2e8ff9255d8818bf4799cc782666a0f01ce9c59d 100644 (file)
--- a/tests/lib/Updater/ChangesCheckTest.php
+++ b/tests/lib/Updater/ChangesCheckTest.php
@@ -380,4 +380,21 @@ class ChangesCheckTest extends TestCase {
                $this->assertTrue(isset($data['whatsNew']['en']['regular']));
                $this->assertTrue(isset($data['changelogURL']));
        }
+
+       public function testGetChangesForVersionEmptyData() {
+               $entry = $this->createMock(ChangesResult::class);
+               $entry->expects($this->once())
+                       ->method('__call')
+                       ->with('getData')
+                       ->willReturn('');
+
+               $this->mapper->expects($this->once())
+                       ->method('getChanges')
+                       ->with('13.0.7')
+                       ->willReturn($entry);
+
+               $this->expectException(DoesNotExistException::class);
+               /** @noinspection PhpUnhandledExceptionInspection */
+               $this->checker->getChangesForVersion('13.0.7');
+       }
 }