]> source.dussan.org Git - sonarqube.git/commitdiff
SONAR-10040 add length validation to Settings ws
authorGuillaume Jambet <guillaume.jambet@sonarsource.com>
Fri, 3 Nov 2017 16:28:21 +0000 (17:28 +0100)
committerGuillaume Jambet <guillaume.jambet@gmail.com>
Wed, 8 Nov 2017 12:51:31 +0000 (13:51 +0100)
server/sonar-server/src/main/java/org/sonar/server/setting/ws/SetAction.java

index b255d1ecafeca3efe784e7e8ce66538c7dc8d78f..a4e23832f4592c9e57aaaabf1897ee4f1b2d36cc 100644 (file)
@@ -71,6 +71,7 @@ import static org.sonarqube.ws.client.setting.SettingsWsParameters.PARAM_VALUES;
 public class SetAction implements SettingsWsAction {
   private static final Collector<CharSequence, ?, String> COMMA_JOINER = Collectors.joining(",");
   private static final String MSG_NO_EMPTY_VALUE = "A non empty value must be provided";
+  private static final int VALUE_MAXIMUM_LENGTH = 4000;
 
   private final PropertyDefinitions propertyDefinitions;
   private final DbClient dbClient;
@@ -114,6 +115,7 @@ public class SetAction implements SettingsWsAction {
       .setRequired(true);
 
     action.createParam(PARAM_VALUE)
+      .setMaximumLength(VALUE_MAXIMUM_LENGTH)
       .setDescription("Setting value. To reset a value, please use the reset web service.")
       .setExampleValue("git@github.com:SonarSource/sonarqube.git");