Redirect if user does not exist on admin pages (#20981) (#21059)

Backport #20981

When on /admin/users/ endpoints if the user is no longer in the DB,
redirect instead of causing a http 500.

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>

diff --git a/routers/web/admin/users.go b/routers/web/admin/users.go
index c37ecfd71ea9044a9d3e028add3622afbb899f57..39b212bbc316bd8fb0bbe76846498155bae1bbe6 100644 (file)
--- a/routers/web/admin/users.go
+++ b/routers/web/admin/users.go
@@ -209,7 +209,11 @@ func NewUserPost(ctx *context.Context) {
 func prepareUserInfo(ctx *context.Context) *user_model.User {
        u, err := user_model.GetUserByID(ctx.ParamsInt64(":userid"))
        if err != nil {
-               ctx.ServerError("GetUserByID", err)
+               if user_model.IsErrUserNotExist(err) {
+                       ctx.Redirect(setting.AppSubURL + "/admin/users")
+               } else {
+                       ctx.ServerError("GetUserByID", err)
+               }
                return nil
        }
        ctx.Data["User"] = u