]> source.dussan.org Git - jquery.git/commitdiff
Fix unit tests in firefox 4 and opera 11, passing null or undefined to indexOf was...
authortimmywil <tim.willison@thisismedium.com>
Mon, 11 Apr 2011 15:54:55 +0000 (11:54 -0400)
committertimmywil <tim.willison@thisismedium.com>
Mon, 11 Apr 2011 15:54:55 +0000 (11:54 -0400)
src/traversing.js

index fb5946bba84634cdc7893b4c80e40721ac3a73d1..485de56d468722989d20027188173af6b8fe6373 100644 (file)
@@ -298,13 +298,18 @@ jQuery.extend({
 
 // Implement the identical functionality for filter and not
 function winnow( elements, qualifier, keep ) {
+
+       // Can't pass null or undefined to indexOf in Firefox 4
+       // Set to 0 to skip string check
+       qualifier = qualifier || 0;
+
        if ( jQuery.isFunction( qualifier ) ) {
                return jQuery.grep(elements, function( elem, i ) {
                        var retVal = !!qualifier.call( elem, i, elem );
                        return retVal === keep;
                });
 
-       } else if ( qualifier && qualifier.nodeType ) {
+       } else if ( qualifier.nodeType ) {
                return jQuery.grep(elements, function( elem, i ) {
                        return (elem === qualifier) === keep;
                });