Fixed #1070 by converting all setAttribute() values to a string which is what all...

diff --git a/src/core.js b/src/core.js
index 0ebc61dff1447095bb67615e4ac9bf8c71d4dce7..39aa65be4523d9d2fa41275384bd4ff28df2e19b 100644 (file)
--- a/src/core.js
+++ b/src/core.js
@@ -1042,7 +1042,8 @@ jQuery.extend({
                                if ( name == "type" && jQuery.nodeName( elem, "input" ) && elem.parentNode )
                                        throw "type property can't be changed";
 
-                               elem.setAttribute( name, value );
+                               // convert the value to a string (all browsers do this but IE) see #1070
+                               elem.setAttribute( name, "" + value );
                        }
 
                        if ( jQuery.browser.msie && /href|src/.test( name ) && !jQuery.isXMLDoc( elem ) ) 

diff --git a/test/unit/core.js b/test/unit/core.js
index e71de2dba3393321587289c1cb9690e3409b7bc2..f77d1f8970106160bf1f0153ef59ddf59f578626 100644 (file)
--- a/test/unit/core.js
+++ b/test/unit/core.js
@@ -276,7 +276,7 @@ test("attr(Hash)", function() {
 });
 
 test("attr(String, Object)", function() {
-       expect(13);
+       expect(16);
        var div = $("div");
        div.attr("foo", "bar");
        var pass = true;
@@ -302,6 +302,14 @@ test("attr(String, Object)", function() {
        $("#name").attr('maxLength', '10');
        ok( document.getElementById('name').maxLength == '10', 'Set maxlength attribute' );
 
+       // for #1070
+       $("#name").attr('someAttr', '0');
+       equals( $("#name").attr('someAttr'), '0', 'Set attribute to a string of "0"' );
+       $("#name").attr('someAttr', 0);
+       equals( $("#name").attr('someAttr'), 0, 'Set attribute to the number 0' );
+       $("#name").attr('someAttr', 1);
+       equals( $("#name").attr('someAttr'), 1, 'Set attribute to the number 1' );
+
        reset();
 
        var type = $("#check2").attr('type');