]> source.dussan.org Git - vaadin-framework.git/commitdiff
Do not allow setting height for components that do not support it
authorArtur Signell <artur@vaadin.com>
Tue, 20 Dec 2011 14:26:06 +0000 (16:26 +0200)
committerArtur Signell <artur@vaadin.com>
Wed, 21 Dec 2011 07:10:41 +0000 (09:10 +0200)
tests/testbench/com/vaadin/tests/components/AbstractComponentContainerTest.java

index 0c9c9c4ae266c8346ba65525289b215ec53e8849..2fef7949282c34064a7b7f103c4729443ed80709 100644 (file)
@@ -1,5 +1,6 @@
 package com.vaadin.tests.components;\r
 \r
+import java.util.HashSet;\r
 import java.util.Iterator;\r
 import java.util.LinkedHashMap;\r
 \r
@@ -284,6 +285,11 @@ public abstract class AbstractComponentContainerTest<T extends AbstractComponent
         addCommands.put("PopupDateField", addPopupDateFieldCommand);\r
         addCommands.put("VerticalSplitPanel", addVerticalSplitPanelCommand);\r
         addCommands.put("HorizontalSplitPanel", addHorizontalSplitPanelCommand);\r
+\r
+        HashSet<String> noVerticalSize = new HashSet<String>();\r
+        noVerticalSize.add("TextField");\r
+        noVerticalSize.add("Button");\r
+\r
         // addCommands.put("AbsoluteLayout", addAbsoluteLayoutCommand);\r
         // addCommands.put("HorizontalLayout", addHorizontalLayoutCommand);\r
         // addCommands.put("VerticalLayout", addVerticalLayoutCommand);\r
@@ -303,6 +309,10 @@ public abstract class AbstractComponentContainerTest<T extends AbstractComponent
             createCategory(componentCategory, subCategory);\r
 \r
             for (ComponentSize size : sizes) {\r
+                if (size.getHeight() != null\r
+                        && noVerticalSize.contains(componentCategory)) {\r
+                    continue;\r
+                }\r
                 createClickAction(size.toString(), componentCategory,\r
                         addCommands.get(componentCategory), size);\r
             }\r