Always upload psalm result to github

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

diff --git a/.github/workflows/static-code-analysis.yml b/.github/workflows/static-code-analysis.yml
index 1529619918ae3975686eeee92b7a4e189b890d12..e09cf0825898411bb3ed82a94096e876676ba939 100644 (file)
--- a/.github/workflows/static-code-analysis.yml
+++ b/.github/workflows/static-code-analysis.yml
@@ -26,10 +26,11 @@ jobs:
         run: composer i
 
       - name: Psalm
-        run: composer run psalm -- --monochrome --no-progress --output-format=github --update-baseline --report=results.sarif || ( git diff -- . ':!lib/composer' && exit 1 )
+        run: composer run psalm -- --monochrome --no-progress --output-format=github --update-baseline --report=results.sarif
       - name: Show potential changes in Psalm baseline
         run: git diff -- . ':!lib/composer'
       - name: Upload Analysis results to GitHub
+        if: always()
         uses: github/codeql-action/upload-sarif@v2
         with:
           sarif_file: results.sarif
@@ -44,14 +45,15 @@ jobs:
       - name: Set up php
         uses: shivammathur/setup-php@master
         with:
-          php-version: 8.0
+          php-version: '8.0'
           extensions: ctype,curl,dom,fileinfo,gd,intl,json,mbstring,openssl,pdo_sqlite,posix,sqlite,xml,zip
           coverage: none
       - name: Composer install
         run: composer i
       - name: Psalm taint analysis
-        run: composer run psalm -- --monochrome --no-progress --output-format=github --update-baseline --report=results.sarif --taint-analysis || ( git diff -- . ':!lib/composer' && exit 1 )
+        run: composer run psalm -- --monochrome --no-progress --output-format=github --report=results.sarif --taint-analysis
       - name: Upload Security Analysis results to GitHub
+        if: always()
         uses: github/codeql-action/upload-sarif@v2
         with:
           sarif_file: results.sarif
@@ -78,6 +80,6 @@ jobs:
         run: composer i
 
       - name: Psalm
-        run: composer run psalm -- -c psalm-ocp.xml --monochrome --no-progress --output-format=github --update-baseline || ( git diff -- . ':!lib/composer' && exit 1 )
+        run: composer run psalm -- -c psalm-ocp.xml --monochrome --no-progress --output-format=github --update-baseline
       - name: Show potential changes in Psalm baseline
         run: git diff -- . ':!lib/composer'