Restrict requested app to apps directory

diff --git a/lib/base.php b/lib/base.php
index cc715afac5d21b2cd416f6c4d70e1df2889b7f99..fdb682bf5032a60c6d61d7a8779bad0ce83914a1 100644 (file)
--- a/lib/base.php
+++ b/lib/base.php
@@ -437,7 +437,7 @@ class OC{
                register_shutdown_function(array('OC_Helper','cleanTmp'));
                
                //parse the given parameters
-               self::$REQUESTEDAPP = (isset($_GET['app'])?str_replace('\0', '', strip_tags($_GET['app'])):OC_Config::getValue('defaultapp', 'files'));
+               self::$REQUESTEDAPP = (isset($_GET['app'])?str_replace(array('\0', '/', '\\', '..'), '', strip_tags($_GET['app'])):OC_Config::getValue('defaultapp', 'files'));
                if(substr_count(self::$REQUESTEDAPP, '?') != 0){
                        $app = substr(self::$REQUESTEDAPP, 0, strpos(self::$REQUESTEDAPP, '?'));
                        $param = substr(self::$REQUESTEDAPP, strpos(self::$REQUESTEDAPP, '?') + 1);