[bug-49202] add PERCENTRANK function

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1892078 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/poi/src/main/java/org/apache/poi/ss/formula/functions/PercentRank.java b/poi/src/main/java/org/apache/poi/ss/formula/functions/PercentRank.java
index 03a9ae54bcfab7e44503c4ccf62c1e327d36a89e..115adf647e1b2e9b9f8f21b863ab2a87eadd5c4a 100644 (file)
--- a/poi/src/main/java/org/apache/poi/ss/formula/functions/PercentRank.java
+++ b/poi/src/main/java/org/apache/poi/ss/formula/functions/PercentRank.java
@@ -89,6 +89,9 @@ public final class PercentRank implements Function {
             try {
                 ValueEval ev = OperandResolver.getSingleValue(args[2], srcRowIndex, srcColumnIndex);
                 significance = OperandResolver.coerceValueToInt(ev);
+                if (significance < 1) {
+                    return ErrorEval.NUM_ERROR;
+                }
             } catch (EvaluationException e) {
                 return e.getErrorEval();
             }

diff --git a/poi/src/test/java/org/apache/poi/ss/formula/functions/TestPercentRank.java b/poi/src/test/java/org/apache/poi/ss/formula/functions/TestPercentRank.java
index 6d96426dd98a8575c9d01d5b240218e84bce8c7b..3892a3eb1d284d2938d351ffb10ce84c42a4ce87 100644 (file)
--- a/poi/src/test/java/org/apache/poi/ss/formula/functions/TestPercentRank.java
+++ b/poi/src/test/java/org/apache/poi/ss/formula/functions/TestPercentRank.java
@@ -57,6 +57,7 @@ public class TestPercentRank {
             confirmErrorResult(fe, cell, "PERCENTRANK(A2:A11,0)", FormulaError.NA);
             confirmErrorResult(fe, cell, "PERCENTRANK(A2:A11,100)", FormulaError.NA);
             confirmErrorResult(fe, cell, "PERCENTRANK(B2:B11,100)", FormulaError.NUM);
+            confirmErrorResult(fe, cell, "PERCENTRANK(A2:A11,8,0)", FormulaError.NUM);
         }
     }