Don't use package private classes when overriding a public interface

Change-Id: If8522d4e02254766e3310a70e42badafa5ab9768
Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>

diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/DfsRefDatabase.java b/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/DfsRefDatabase.java
index 6784b493a90051fcd53744056f0450f10df82f70..593aaac15bff0d5275a004f59b7edbca9899b2fd 100644 (file)
--- a/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/DfsRefDatabase.java
+++ b/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/DfsRefDatabase.java
@@ -56,6 +56,7 @@ import org.eclipse.jgit.lib.ObjectIdRef;
 import org.eclipse.jgit.lib.Ref;
 import org.eclipse.jgit.lib.RefDatabase;
 import org.eclipse.jgit.lib.RefRename;
+import org.eclipse.jgit.lib.RefUpdate;
 import org.eclipse.jgit.lib.SymbolicRef;
 import org.eclipse.jgit.revwalk.RevObject;
 import org.eclipse.jgit.revwalk.RevTag;
@@ -211,7 +212,7 @@ public abstract class DfsRefDatabase extends RefDatabase {
        }
 
        @Override
-       public DfsRefUpdate newUpdate(String refName, boolean detach)
+       public RefUpdate newUpdate(String refName, boolean detach)
                        throws IOException {
                boolean detachingSymbolicRef = false;
                Ref ref = getOneRef(refName);
@@ -233,8 +234,8 @@ public abstract class DfsRefDatabase extends RefDatabase {
        @Override
        public RefRename newRename(String fromName, String toName)
                        throws IOException {
-               DfsRefUpdate src = newUpdate(fromName, true);
-               DfsRefUpdate dst = newUpdate(toName, true);
+               RefUpdate src = newUpdate(fromName, true);
+               RefUpdate dst = newUpdate(toName, true);
                return new DfsRefRename(src, dst);
        }
 

diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/DfsRefRename.java b/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/DfsRefRename.java
index a4cb791550c5aeea197261b600d357dc6f34380c..d9c2bc7467943c660e16ed4fe25f4bbbd253b147 100644 (file)
--- a/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/DfsRefRename.java
+++ b/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/DfsRefRename.java
@@ -47,10 +47,11 @@ import java.io.IOException;
 
 import org.eclipse.jgit.lib.ObjectId;
 import org.eclipse.jgit.lib.RefRename;
+import org.eclipse.jgit.lib.RefUpdate;
 import org.eclipse.jgit.lib.RefUpdate.Result;
 
 final class DfsRefRename extends RefRename {
-       DfsRefRename(DfsRefUpdate src, DfsRefUpdate dst) {
+       DfsRefRename(RefUpdate src, RefUpdate dst) {
                super(src, dst);
        }