Make inner classes static in http code

Static classes are preferrable to keep unwanted dependencies away,
and they have one less member field.

Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>

diff --git a/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/AsIsServiceTest.java b/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/AsIsServiceTest.java
index ea937481d4bea9acdf553826da00037482d2b439..2650db2fa865bfe5d618505b306f8c40ce444183 100644 (file)
--- a/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/AsIsServiceTest.java
+++ b/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/AsIsServiceTest.java
@@ -112,7 +112,7 @@ public class AsIsServiceTest extends LocalDiskRepositoryTestCase {
                service.access(new R("bob", "1.2.3.4"), db);
        }
 
-       private final class R extends HttpServletRequestWrapper {
+       private static final class R extends HttpServletRequestWrapper {
                private final String user;
 
                private final String host;

diff --git a/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/DefaultReceivePackFactoryTest.java b/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/DefaultReceivePackFactoryTest.java
index 5338caaa488b3d4edc367834836103584d8f69a8..4d05a085c68c0ec8081d32b2b3a8f76a66408536 100644 (file)
--- a/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/DefaultReceivePackFactoryTest.java
+++ b/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/DefaultReceivePackFactoryTest.java
@@ -174,7 +174,7 @@ public class DefaultReceivePackFactoryTest extends LocalDiskRepositoryTestCase {
                assertNotNull("have ReceivePack", rp);
        }
 
-       private final class R extends HttpServletRequestWrapper {
+       private static final class R extends HttpServletRequestWrapper {
                private final String user;
 
                private final String host;

diff --git a/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/DefaultUploadPackFactoryTest.java b/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/DefaultUploadPackFactoryTest.java
index 8f57d40afe8f09a7adbb2d4e9855873ef3b223b7..423361e06b72f2c116357df8963bd4c29522d928 100644 (file)
--- a/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/DefaultUploadPackFactoryTest.java
+++ b/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/DefaultUploadPackFactoryTest.java
@@ -136,7 +136,7 @@ public class DefaultUploadPackFactoryTest extends LocalDiskRepositoryTestCase {
                assertSame(db, up.getRepository());
        }
 
-       private final class R extends HttpServletRequestWrapper {
+       private static final class R extends HttpServletRequestWrapper {
                private final String user;
 
                private final String host;