Fixed widget comparisons to avoid reattaching children (#9807)

Change-Id: Iae6de2bf3d6cbc39fc2b6285eb1e514710e98818

diff --git a/client/src/com/vaadin/client/ui/accordion/VAccordion.java b/client/src/com/vaadin/client/ui/accordion/VAccordion.java
index ce973f96300ef9011b3472344e237a9294b0549b..70398c238f7239556038b09708336e8fa61374f4 100644 (file)
--- a/client/src/com/vaadin/client/ui/accordion/VAccordion.java
+++ b/client/src/com/vaadin/client/ui/accordion/VAccordion.java
@@ -131,7 +131,7 @@ public class VAccordion extends VTabsheetBase {
 
         Widget itemWidget = item.getComponent();
         if (tabContent != null) {
-            if (tabContent != itemWidget) {
+            if (tabContent.getWidget() != itemWidget) {
                 /*
                  * This is not the same widget as before, find out if it has
                  * been moved
@@ -542,8 +542,14 @@ public class VAccordion extends VTabsheetBase {
     @Override
     protected ComponentConnector getTab(int index) {
         if (index < getWidgetCount()) {
-            Widget w = getStackItem(index);
-            return ConnectorMap.get(client).getConnector(w);
+            StackItem stackItem = getStackItem(index);
+            if (stackItem == null) {
+                return null;
+            }
+            Widget w = stackItem.getChildWidget();
+            if (w != null) {
+                return ConnectorMap.get(client).getConnector(w);
+            }
         }
 
         return null;