Make the tests buildable by bazel test

All the errorprone checkers fail in many existing places of the
codebase, making it impossible to run bazel test. Downgrade all to
":WARN".

MergeToolTest is asserting a wrong error line, but the line seems
different between bazel and mvn test runs. Therefore we don't fix it and
simply run

```
bazel test -- //... -//org.eclipse.jgit.pgm.test:pgm
```

Change-Id: I44913ebc70dcc934cb69481cc3ff9ae0d8059707

diff --git a/tools/BUILD b/tools/BUILD
index 1d29d7660431e4d25e98ffe1a00a328d3597f216..c2b2366c495cdf6cca8e0178cacf49a33a8c0451 100644 (file)
--- a/tools/BUILD
+++ b/tools/BUILD
@@ -53,7 +53,7 @@ java_package_configuration(
         "-Xep:ArraysAsListPrimitiveArray:ERROR",
         "-Xep:ArrayToString:ERROR",
         "-Xep:AssertEqualsArgumentOrderChecker:ERROR",
-        "-Xep:AssertionFailureIgnored:ERROR",
+        "-Xep:AssertionFailureIgnored:WARN",
         "-Xep:AsyncCallableReturnsNull:ERROR",
         "-Xep:AsyncFunctionReturnsNull:ERROR",
         "-Xep:AutoValueConstructorOrderChecker:ERROR",
@@ -62,7 +62,7 @@ java_package_configuration(
         "-Xep:AutoValueSubclassLeaked:WARN",
         "-Xep:BadAnnotationImplementation:ERROR",
         "-Xep:BadComparable:ERROR",
-        "-Xep:BadImport:ERROR",
+        "-Xep:BadImport:WARN",
         "-Xep:BadInstanceof:ERROR",
         "-Xep:BadShiftAmount:ERROR",
         "-Xep:BanSerializableRead:ERROR",
@@ -75,8 +75,8 @@ java_package_configuration(
         "-Xep:CacheLoaderNull:ERROR",
         "-Xep:CannotMockFinalClass:ERROR",
         "-Xep:CanonicalDuration:ERROR",
-        "-Xep:CatchAndPrintStackTrace:ERROR",
-        "-Xep:CatchFail:ERROR",
+        "-Xep:CatchAndPrintStackTrace:WARN",
+        "-Xep:CatchFail:WARN",
         "-Xep:ChainedAssertionLosesContext:ERROR",
         "-Xep:ChainingConstructorIgnoresParameter:ERROR",
         "-Xep:CharacterGetNumericValue:ERROR",
@@ -123,7 +123,7 @@ java_package_configuration(
         "-Xep:DurationGetTemporalUnit:ERROR",
         "-Xep:DurationTemporalUnit:ERROR",
         "-Xep:DurationToLongTimeUnit:ERROR",
-        "-Xep:EmptyBlockTag:ERROR",
+        "-Xep:EmptyBlockTag:WARN",
         "-Xep:EmptyCatch:ERROR",
         "-Xep:EmptySetMultibindingContributions:ERROR",
         "-Xep:EqualsGetClass:ERROR",
@@ -158,7 +158,7 @@ java_package_configuration(
         "-Xep:FromTemporalAccessor:ERROR",
         "-Xep:FunctionalInterfaceClash:ERROR",
         "-Xep:FunctionalInterfaceMethodChanged:ERROR",
-        "-Xep:FutureReturnValueIgnored:ERROR",
+        "-Xep:FutureReturnValueIgnored:WARN",
         "-Xep:FuturesGetCheckedIllegalExceptionType:ERROR",
         "-Xep:GetClassOnAnnotation:ERROR",
         "-Xep:GetClassOnClass:ERROR",
@@ -167,7 +167,7 @@ java_package_configuration(
         "-Xep:GuiceAssistedInjectScoping:ERROR",
         "-Xep:GuiceAssistedParameters:ERROR",
         "-Xep:HashtableContains:ERROR",
-        "-Xep:HidingField:ERROR",
+        "-Xep:HidingField:WARN",
         "-Xep:IdentityBinaryExpression:ERROR",
         "-Xep:IdentityHashMapBoxing:ERROR",
         "-Xep:IdentityHashMapUsage:ERROR",
@@ -251,7 +251,7 @@ java_package_configuration(
         "-Xep:LockOnBoxedPrimitive:ERROR",
         "-Xep:LogicalAssignment:ERROR",
         "-Xep:LongFloatConversion:ERROR",
-        "-Xep:LongLiteralLowerCaseSuffix:ERROR",
+        "-Xep:LongLiteralLowerCaseSuffix:WARN",
         "-Xep:LoopConditionChecker:ERROR",
         "-Xep:LoopOverCharArray:ERROR",
         "-Xep:LossyPrimitiveCompare:ERROR",
@@ -270,7 +270,7 @@ java_package_configuration(
         "-Xep:MixedDescriptors:ERROR",
         "-Xep:MixedMutabilityReturnType:WARN",
         "-Xep:MockitoUsage:ERROR",
-        "-Xep:ModifiedButNotUsed:ERROR",
+        "-Xep:ModifiedButNotUsed:WARN",
         "-Xep:ModifyCollectionInEnhancedForLoop:ERROR",
         "-Xep:ModifyingCollectionWithItself:ERROR",
         "-Xep:ModifySourceCollectionInStream:ERROR",
@@ -323,7 +323,7 @@ java_package_configuration(
         "-Xep:PreferredInterfaceType:OFF",
         "-Xep:PrimitiveAtomicReference:ERROR",
         "-Xep:PrivateSecurityContractProtoAccess:ERROR",
-        "-Xep:ProtectedMembersInFinalClass:ERROR",
+        "-Xep:ProtectedMembersInFinalClass:WARN",
         "-Xep:ProtoBuilderReturnValueIgnored:ERROR",
         "-Xep:ProtocolBufferOrdinal:ERROR",
         "-Xep:ProtoDurationGetSecondsGetNano:ERROR",
@@ -372,7 +372,7 @@ java_package_configuration(
         "-Xep:ThreadJoinLoop:ERROR",
         "-Xep:ThreadLocalUsage:ERROR",
         "-Xep:ThreadPriorityCheck:ERROR",
-        "-Xep:ThreeLetterTimeZoneID:ERROR",
+        "-Xep:ThreeLetterTimeZoneID:WARN",
         "-Xep:ThrowIfUncheckedKnownChecked:ERROR",
         "-Xep:ThrowNull:ERROR",
         "-Xep:TimeUnitConversionChecker:ERROR",
@@ -389,14 +389,14 @@ java_package_configuration(
         "-Xep:TypeParameterQualifier:ERROR",
         "-Xep:TypeParameterShadowing:ERROR",
         "-Xep:TypeParameterUnusedInFormals:ERROR",
-        "-Xep:UndefinedEquals:ERROR",
-        "-Xep:UnescapedEntity:ERROR",
+        "-Xep:UndefinedEquals:WARN",
+        "-Xep:UnescapedEntity:WARN",
         "-Xep:UnnecessaryAssignment:ERROR",
         "-Xep:UnnecessaryCheckNotNull:ERROR",
         "-Xep:UnnecessaryLambda:ERROR",
         "-Xep:UnnecessaryMethodInvocationMatcher:ERROR",
         "-Xep:UnnecessaryMethodReference:ERROR",
-        "-Xep:UnnecessaryParentheses:ERROR",
+        "-Xep:UnnecessaryParentheses:WARN",
         "-Xep:UnnecessaryTypeArgument:ERROR",
         "-Xep:UnrecognisedJavadocTag:ERROR",
         "-Xep:UnsafeFinalization:ERROR",
@@ -405,12 +405,12 @@ java_package_configuration(
         "-Xep:UnusedAnonymousClass:ERROR",
         "-Xep:UnusedCollectionModifiedInPlace:ERROR",
         "-Xep:UnusedException:ERROR",
-        "-Xep:UnusedMethod:ERROR",
+        "-Xep:UnusedMethod:WARN",
         "-Xep:UnusedNestedClass:ERROR",
-        "-Xep:UnusedVariable:ERROR",
+        "-Xep:UnusedVariable:WARN",
         "-Xep:URLEqualsHashCode:ERROR",
         "-Xep:UseBinds:ERROR",
-        "-Xep:UseCorrectAssertInTests:ERROR",
+        "-Xep:UseCorrectAssertInTests:WARN",
         "-Xep:VariableNameSameAsType:ERROR",
         "-Xep:VarTypeName:ERROR",
         "-Xep:WaitNotInLoop:ERROR",