]> source.dussan.org Git - jgit.git/commitdiff
DirCacheCheckoutTest#testCheckoutHierarchy: Add missing call to fail() 82/130182/1
authorDavid Pursehouse <david.pursehouse@gmail.com>
Sat, 29 Sep 2018 03:59:03 +0000 (12:59 +0900)
committerDavid Pursehouse <david.pursehouse@gmail.com>
Sat, 29 Sep 2018 03:59:03 +0000 (12:59 +0900)
Error Prone reports:

  Not calling fail() when expecting an exception masks bugs

See https://errorprone.info/bugpattern/MissingFail

Change-Id: I463510342bb6e6b99b31a0fe264d953340784393
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
org.eclipse.jgit.test/tst/org/eclipse/jgit/lib/DirCacheCheckoutTest.java

index 7cb91a2064cc7c0f335a0104d8af638e1005ba18..534b323fe6eda595728f5f149ffb6f4db0e12ff9 100644 (file)
@@ -929,6 +929,7 @@ public class DirCacheCheckoutTest extends RepositoryTestCase {
                                                "e/g3"));
                try {
                        checkout();
+                       fail("did not throw CheckoutConflictException");
                } catch (CheckoutConflictException e) {
                        assertWorkDir(mkmap("a", "a", "b/c", "b/c", "d", "d", "e/f",
                                        "e/f", "e/g", "e/g3"));