SONAR-5968 apply feedback

diff --git a/server/sonar-web/src/main/coffee/issues/workspace-list-item-view.coffee b/server/sonar-web/src/main/coffee/issues/workspace-list-item-view.coffee
index 8c52c44898fb282f5cec2a63cc95d7c09a601ec2..50cd234bac6e8b15a6ac92e1db22e9a554e4bb06 100644 (file)
--- a/server/sonar-web/src/main/coffee/issues/workspace-list-item-view.coffee
+++ b/server/sonar-web/src/main/coffee/issues/workspace-list-item-view.coffee
@@ -30,6 +30,7 @@ define [
   $ = jQuery
 
   SHOULD_NULL =
+    any: ['issues']
     resolutions: ['resolved']
     resolved: ['resolutions']
     assignees: ['assigned']
@@ -71,6 +72,7 @@ define [
       @popup.on 'select', (property, value) =>
         obj = {}
         obj[property] = '' + value
+        SHOULD_NULL.any.forEach (p) -> obj[p] = null
         if SHOULD_NULL[property]?
           SHOULD_NULL[property].forEach (p) -> obj[p] = null
         @options.app.state.updateFilter obj

diff --git a/server/sonar-web/src/main/hbs/issues/issues-issue-filter-form.hbs b/server/sonar-web/src/main/hbs/issues/issues-issue-filter-form.hbs
index f8f6f1d41fa2cfb5f337b42264f8ce216827294f..0151574969872af4eb90a8b52a3c701d57d9b8ac 100644 (file)
--- a/server/sonar-web/src/main/hbs/issues/issues-issue-filter-form.hbs
+++ b/server/sonar-web/src/main/hbs/issues/issues-issue-filter-form.hbs
@@ -19,10 +19,6 @@
     </a>
   {{/if}}
 
-  <a href="#" class="issue-action-option" data-property="rules" data-value="{{rule}}">
-    {{limitString ruleName}}
-  </a>
-
   {{#if assignee}}
     <a href="#" class="issue-action-option" data-property="assignees" data-value="{{assignee}}">
       {{t 'assigned_to'}} {{assigneeName}}
@@ -43,14 +39,17 @@
     </a>
   {{/if}}
 
-  {{#notEmpty tags}}
-    <hr>
-    {{#each tags}}
-      <a href="#" class="issue-action-option" data-property="tags" data-value="{{this}}">
-        <i class="icon-tags icon-half-transparent"></i>&nbsp;{{this}}
-      </a>
-    {{/each}}
-  {{/notEmpty}}
+  <hr>
+
+  <a href="#" class="issue-action-option" data-property="rules" data-value="{{rule}}">
+    {{limitString ruleName}}
+  </a>
+
+  {{#each tags}}
+    <a href="#" class="issue-action-option" data-property="tags" data-value="{{this}}">
+      <i class="icon-tags icon-half-transparent"></i>&nbsp;{{this}}
+    </a>
+  {{/each}}
 
   <hr>
 

diff --git a/server/sonar-web/src/main/js/common/handlebars-extensions.js b/server/sonar-web/src/main/js/common/handlebars-extensions.js
index fd82874005ad0c6c6497fcc174be76c4d4e123ad..a77e318c13e27be133728cee4a5bdaa3593eeb33 100644 (file)
--- a/server/sonar-web/src/main/js/common/handlebars-extensions.js
+++ b/server/sonar-web/src/main/js/common/handlebars-extensions.js
@@ -492,7 +492,8 @@
   });
 
   Handlebars.registerHelper('limitString', function (str) {
-    return str.substr(0, 30) + '...';
+    var LIMIT = 30;
+    return str.length > LIMIT ? str.substr(0, LIMIT) + '...' : str;
   });
 
 })();