]> source.dussan.org Git - nextcloud-server.git/commitdiff
fixes auto-detecting UUID attributes 20047/head
authorArthur Schiwon <blizzz@arthur-schiwon.de>
Thu, 19 Mar 2020 18:42:46 +0000 (19:42 +0100)
committerbackportbot[bot] <backportbot[bot]@users.noreply.github.com>
Fri, 20 Mar 2020 10:09:07 +0000 (10:09 +0000)
the continue (and later the early return) avoided proper looping over the
attribute candidates.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
apps/user_ldap/lib/Access.php

index 0cf3e4a91e3713468379d4eb604905c4f23df136..e7d34b16fa9c7ae5b51757b1580f1a50fd9c4e99 100644 (file)
@@ -1730,7 +1730,6 @@ class Access extends LDAPUtility {
                                        $this->connection->$uuidAttr = $attribute;
                                        return true;
                                }
-                               continue;
                        }
 
                        $value = $this->readAttribute($dn, $attribute);
@@ -1746,9 +1745,6 @@ class Access extends LDAPUtility {
                                $this->connection->$uuidAttr = $attribute;
                                $this->connection->writeToCache($uuidAttr, $attribute);
                                return true;
-                       } elseif ($value === false) {
-                               // record not available
-                               return false;
                        }
                }
                \OC::$server->getLogger()->debug('Could not autodetect the UUID attribute', ['app' => 'user_ldap']);