From: Martin Stockhammer <martin_s@apache.org>
Date: Tue, 12 Jan 2021 17:07:40 +0000 (+0100)
Subject: Adding check for property value change
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=02a57faa0e2e6601900c20b4623a3e9b67c866aa;p=archiva.git

Adding check for property value change
---

diff --git a/archiva-modules/archiva-web/archiva-webapp/src/main/archiva-web/src/app/modules/security/security-configuration/security-properties/security-properties.component.html b/archiva-modules/archiva-web/archiva-webapp/src/main/archiva-web/src/app/modules/security/security-configuration/security-properties/security-properties.component.html
index b7f07258c..c994557a3 100644
--- a/archiva-modules/archiva-web/archiva-webapp/src/main/archiva-web/src/app/modules/security/security-configuration/security-properties/security-properties.component.html
+++ b/archiva-modules/archiva-web/archiva-webapp/src/main/archiva-web/src/app/modules/security/security-configuration/security-properties/security-properties.component.html
@@ -39,10 +39,10 @@
             </thead>
             <tbody>
             <tr *ngFor="let propertyEntry  of propertyItem.data" >
-                <td>{{propertyEntry.key}}</td>
-                <td *ngIf="isEdit(propertyEntry.key)"><input class="form-control" type="text" [(ngModel)]="propertyValue"></td>
-                <td *ngIf="!isEdit(propertyEntry.key)">{{propertyEntry.value}}</td>
-                <td>
+                <td class="align-middle">{{propertyEntry.key}}</td>
+                <td class="align-middle" *ngIf="isEdit(propertyEntry.key)"><input class="form-control" type="text" [(ngModel)]="propertyValue"></td>
+                <td class="align-middle" *ngIf="!isEdit(propertyEntry.key)">{{propertyEntry.value}}</td>
+                <td class="align-middle" >
                     <a [routerLink]="" (click)="toggleEditProperty(propertyEntry)"
                        [attr.title]="'security.config.properties.edit' |translate"><span class="fas fa-edit"></span></a>
                 </td>
diff --git a/archiva-modules/archiva-web/archiva-webapp/src/main/archiva-web/src/app/modules/security/security-configuration/security-properties/security-properties.component.ts b/archiva-modules/archiva-web/archiva-webapp/src/main/archiva-web/src/app/modules/security/security-configuration/security-properties/security-properties.component.ts
index 28e5b9562..1a959872c 100644
--- a/archiva-modules/archiva-web/archiva-webapp/src/main/archiva-web/src/app/modules/security/security-configuration/security-properties/security-properties.component.ts
+++ b/archiva-modules/archiva-web/archiva-webapp/src/main/archiva-web/src/app/modules/security/security-configuration/security-properties/security-properties.component.ts
@@ -35,6 +35,7 @@ export class SecurityPropertiesComponent extends SortedTableComponent<PropertyEn
 
     editProperty:string='';
     propertyValue:string='';
+    originPropertyValue:string='';
 
     constructor(translator: TranslateService, private securityService: SecurityService, private toastService: ToastService) {
         super(translator, function (searchTerm: string, offset: number, limit: number, orderBy: string[], order: string): Observable<PagedResult<PropertyEntry>> {
@@ -53,14 +54,16 @@ export class SecurityPropertiesComponent extends SortedTableComponent<PropertyEn
 
     updateProperty(key:string, value:string) {
         console.log("Updating "+key+"="+value)
-        this.securityService.updateProperty(key, value).subscribe(
-            ()=>{
-                this.toastService.showSuccessByKey('security-properties', 'security.config.properties.edit_success')
-            },
-            (error: ErrorResult) => {
-                this.toastService.showErrorByKey('security-properties', 'security.config.properties.edit_failure', {error:error.firstMessageString()})
-            }
-        );
+        if (this.propertyValue!=this.originPropertyValue) {
+            this.securityService.updateProperty(key, value).subscribe(
+                () => {
+                    this.toastService.showSuccessByKey('security-properties', 'security.config.properties.edit_success')
+                },
+                (error: ErrorResult) => {
+                    this.toastService.showErrorByKey('security-properties', 'security.config.properties.edit_failure', {error: error.firstMessageString()})
+                }
+            );
+        }
     }
 
     toggleEditProperty(propertyEntry:PropertyEntry) : void {
@@ -69,9 +72,11 @@ export class SecurityPropertiesComponent extends SortedTableComponent<PropertyEn
             this.editProperty='';
             this.updateProperty(propertyEntry.key, this.propertyValue);
             this.propertyValue = '';
+            this.originPropertyValue='';
         } else {
             this.editProperty = propertyEntry.key;
             this.propertyValue = propertyEntry.value;
+            this.originPropertyValue = propertyEntry.value;
         }
     }
 }