From: Go MAEDA <maeda@farend.jp>
Date: Fri, 4 Dec 2020 00:40:37 +0000 (+0000)
Subject: Merged r20562 from trunk to 4.1-stable (#33355).
X-Git-Tag: 4.1.2~26
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=02de3a2156276055578b9c04e8ba410f755d3048;p=redmine.git

Merged r20562 from trunk to 4.1-stable (#33355).


git-svn-id: http://svn.redmine.org/redmine/branches/4.1-stable@20563 e93f8b46-1217-0410-a6f0-8f06a7374b81
---

diff --git a/app/views/users/edit.html.erb b/app/views/users/edit.html.erb
index 2a8b6707f..786630869 100644
--- a/app/views/users/edit.html.erb
+++ b/app/views/users/edit.html.erb
@@ -7,7 +7,7 @@
 
 <%=
   page_title = title [l(:label_user_plural), users_path], @user.login
-  page_title.insert(page_title.rindex(' ') + 1, avatar(@user))
+  page_title.insert(page_title.rindex(' ') + 1, avatar(@user).to_s)
 %>
 
 <%= render_tabs user_settings_tabs %>
diff --git a/test/functional/users_controller_test.rb b/test/functional/users_controller_test.rb
index e83cef726..8da207bb0 100644
--- a/test/functional/users_controller_test.rb
+++ b/test/functional/users_controller_test.rb
@@ -708,6 +708,19 @@ class UsersControllerTest < Redmine::ControllerTest
     assert_response 404
   end
 
+  def test_update_with_blank_email_should_not_raise_exception
+    assert_no_difference 'User.count' do
+      with_settings :gravatar_enabled => '1' do
+        put :update, :params => {
+          :id => 2,
+          :user => {:mail => ''}
+        }
+      end
+    end
+    assert_response :success
+    assert_select_error /Email cannot be blank/
+  end
+
   def test_destroy
     assert_difference 'User.count', -1 do
       delete :destroy, :params => {:id => 2}