From: Go MAEDA <maeda@farend.jp>
Date: Mon, 1 Feb 2021 04:22:22 +0000 (+0000)
Subject: Fix project selector on global new issue page not showing all visible projects (... 
X-Git-Tag: 4.2.0~99
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=097e75987b0c9f2dc7334aa1c23a5b3ae8b29163;p=redmine.git

Fix project selector on global new issue page not showing all visible projects (#33419).

Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@20733 e93f8b46-1217-0410-a6f0-8f06a7374b81
---

diff --git a/app/helpers/issues_helper.rb b/app/helpers/issues_helper.rb
index 20a708ca0..566cd1d53 100644
--- a/app/helpers/issues_helper.rb
+++ b/app/helpers/issues_helper.rb
@@ -746,7 +746,7 @@ module IssuesHelper
   def projects_for_select(issue)
     if issue.parent_issue_id.present?
       issue.allowed_target_projects_for_subtask(User.current)
-    elsif issue.new_record? && !issue.copy?
+    elsif @project && issue.new_record? && !issue.copy?
       issue.allowed_target_projects(User.current, 'descendants')
     else
       issue.allowed_target_projects(User.current)
diff --git a/test/functional/issues_controller_test.rb b/test/functional/issues_controller_test.rb
index 1762c7efd..a8296b9bc 100644
--- a/test/functional/issues_controller_test.rb
+++ b/test/functional/issues_controller_test.rb
@@ -3170,6 +3170,18 @@ class IssuesControllerTest < Redmine::ControllerTest
     end
   end
 
+  def test_get_new_global_should_show_all_projects
+    @request.session[:user_id] = 1
+    get :new
+
+    assert_response :success
+
+    assert_select 'select[name=?]', 'issue[project_id]' do
+      assert_select 'option[value=?]', '1'
+      assert_select 'option[value=?]', '2'
+    end
+  end
+
   def test_get_new_should_show_project_selector_for_project_with_subprojects
     @request.session[:user_id] = 2
     get(