From: Alexander Kriegisch <Alexander@Kriegisch.name>
Date: Thu, 1 Feb 2024 10:16:42 +0000 (+0700)
Subject: Workaround for non-English javadoc generation
X-Git-Tag: V1_9_21_1~20
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=0cba9d10b7a4987af5654e3e1fa84c7f76745e23;p=aspectj.git

Workaround for non-English javadoc generation

On my workstation, more recent JDKs generate partly German javadocs.

Background: Avoid non-English javadoc generation. Due to
https://bugs.openjdk.org/browse/JDK-8222793 reoccurring at least in JDKs
19-21 and also being broken in some older JDKs, we cannot rely on just
setting the locale parameter, but also need the 'user.language' and
'user.country' parameters in 'additionalJOptions' as a workaround.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
---

diff --git a/pom.xml b/pom.xml
index 34f3ae69b..9ebfb25e9 100644
--- a/pom.xml
+++ b/pom.xml
@@ -436,6 +436,18 @@
 						<use>true</use>
 						<!-- FIXME: Why does it fail without this parameter? -->
 						<javadocVersion>8</javadocVersion>
+						<!--
+							Avoid non-English javadoc generation. Due to https://bugs.openjdk.org/browse/JDK-8222793 reoccurring at
+							least in JDKs 19-21 and also being broken in some older JDKs, we cannot rely on just setting the locale
+							parameter, but also need the 'user.language' and 'user.country' parameters in 'additionalJOptions' as a
+							workaround.
+						-->
+						<locale>en</locale>
+						<additionalJOptions>
+							<additionalJOption>-J-Dfile.encoding=UTF-8</additionalJOption>
+							<additionalJOption>-J-Duser.language=en</additionalJOption>
+							<additionalJOption>-J-Duser.country=US</additionalJOption>
+						</additionalJOptions>
 					</configuration>
 				</plugin>
 				<plugin>