From: Artur Signell <artur.signell@itmill.com>
Date: Mon, 22 Feb 2010 08:58:38 +0000 (+0000)
Subject: Fixed drag mode support for Tree
X-Git-Tag: 6.7.0.beta1~1988^2~4
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=0cfa16c5880d72891d3969c1dc4a83833b8b327b;p=vaadin-framework.git

Fixed drag mode support for Tree

svn changeset:11449/svn branch:6.3_dd
---

diff --git a/src/com/vaadin/terminal/gwt/client/ui/VTree.java b/src/com/vaadin/terminal/gwt/client/ui/VTree.java
index 9926d2921a..dc6f914389 100644
--- a/src/com/vaadin/terminal/gwt/client/ui/VTree.java
+++ b/src/com/vaadin/terminal/gwt/client/ui/VTree.java
@@ -67,7 +67,7 @@ public class VTree extends FlowPanel implements Paintable, VHasDropHandler {
 
     private boolean rendering;
 
-    private int dragModes;
+    private int dragMode = 0;
 
     private VAbstractDropHandler dropHandler;
 
@@ -150,8 +150,10 @@ public class VTree extends FlowPanel implements Paintable, VHasDropHandler {
 
         selectedIds = uidl.getStringArrayVariableAsSet("selected");
 
-        if (uidl.hasAttribute("dragModes")) {
-            dragModes = uidl.getIntAttribute("dragModes");
+        if (uidl.hasAttribute("dragMode")) {
+            dragMode = uidl.getIntAttribute("dragMode");
+        } else {
+            dragMode = 0;
         }
 
         rendering = false;
@@ -396,7 +398,7 @@ public class VTree extends FlowPanel implements Paintable, VHasDropHandler {
                 showContextMenu(event);
             }
 
-            if (dragModes != 0 || dropHandler != null) {
+            if (dragMode != 0 || dropHandler != null) {
                 if (type == Event.ONMOUSEDOWN) {
                     if (nodeCaptionDiv.isOrHasChild(event.getTarget())) {
                         ApplicationConnection.getConsole().log(
diff --git a/src/com/vaadin/ui/Tree.java b/src/com/vaadin/ui/Tree.java
index 22dd0a4182..5e0e66fae5 100644
--- a/src/com/vaadin/ui/Tree.java
+++ b/src/com/vaadin/ui/Tree.java
@@ -111,12 +111,15 @@ public class Tree extends AbstractSelect implements Container.Hierarchical,
      */
     private boolean initialPaint = true;
 
-    // TODO sort DD members and methods
-    public static int DRAG_SORTABLE = 1;
-    public static int DRAG_OUT = 2;
-    public static int DRAG_NONE = 0;
+    private DragMode dragMode = DragMode.NONE;
 
-    private int itemDragModes = DRAG_OUT;
+    /**
+     * Supported drag modes for Tree.
+     */
+    public enum DragMode {
+        NONE, NODES;
+
+    }
 
     class TreeTransferable extends DataBoundTransferable {
 
@@ -480,8 +483,8 @@ public class Tree extends AbstractSelect implements Container.Hierarchical,
                 target.addAttribute("nullselect", true);
             }
 
-            if (itemDragModes != 0) {
-                target.addAttribute("dragModes", itemDragModes);
+            if (dragMode != DragMode.NONE) {
+                target.addAttribute("dragMode", dragMode.ordinal());
             }
 
         }