From: Timmy Willison <4timmywil@gmail.com>
Date: Mon, 3 Dec 2018 17:03:04 +0000 (-0500)
Subject: Tests: fix dimensions tests in testswarm
X-Git-Tag: 3.4.0~30
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=13f3cd1611d7905c6fadcf2f8a533096b347a6ad;p=jquery.git

Tests: fix dimensions tests in testswarm

Close gh-4248
---

diff --git a/test/unit/dimensions.js b/test/unit/dimensions.js
index 36b07f11e..223e17b0a 100644
--- a/test/unit/dimensions.js
+++ b/test/unit/dimensions.js
@@ -757,7 +757,11 @@ QUnit.test( "outerWidth/Height for table cells and textarea with border-box in I
 		$firstTh = jQuery( "<th style='width: 200px;padding: 5px' />" ),
 		$secondTh = jQuery( "<th style='width: 190px;padding: 5px' />" ),
 		$thirdTh = jQuery( "<th style='width: 180px;padding: 5px' />" ),
-		$td = jQuery( "<td style='height: 20px;padding: 5px;border: 1px solid'>text</td>" ),
+		// Support Firefox 63, Edge 16-17, Android 8, iOS 7-11
+		// These browsers completely ignore the border-box and height settings
+		// The computed height is instead just line-height + border
+		// Either way, what we're doing in css.js is correct
+		$td = jQuery( "<td style='height: 20px;padding: 5px;border: 1px solid;line-height:18px'>text</td>" ),
 		$tbody = jQuery( "<tbody />" ).appendTo( $table ),
 		$textarea = jQuery( "<textarea style='height: 0;padding: 2px;border: 1px solid;box-sizing: border-box' />" ).appendTo( "#qunit-fixture" );
 	jQuery( "<tr />" ).appendTo( $thead ).append( $firstTh );