From: Go MAEDA <maeda@farend.jp>
Date: Tue, 24 Mar 2020 12:16:06 +0000 (+0000)
Subject: Export to PDF fails when subject of parent task is included in issue list (#33103).
X-Git-Tag: 4.2.0~1135
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=1473996f92fd8e77af4736353bcb0190e79b144d;p=redmine.git

Export to PDF fails when subject of parent task is included in issue list (#33103).

Patch by Marius BALTEANU and Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19611 e93f8b46-1217-0410-a6f0-8f06a7374b81
---

diff --git a/lib/redmine/export/pdf/issues_pdf_helper.rb b/lib/redmine/export/pdf/issues_pdf_helper.rb
index 2f73e52a4..b49691695 100644
--- a/lib/redmine/export/pdf/issues_pdf_helper.rb
+++ b/lib/redmine/export/pdf/issues_pdf_helper.rb
@@ -379,7 +379,7 @@ module Redmine
                 cv = issue.visible_custom_field_values.detect {|v| v.custom_field_id == column.custom_field.id}
                 show_value(cv, false)
               else
-                value = issue.send(column.name)
+                value = column.value_object(issue)
                 case column.name
                 when :subject
                   value = "  " * level + value
diff --git a/test/unit/lib/redmine/export/pdf/issues_pdf_test.rb b/test/unit/lib/redmine/export/pdf/issues_pdf_test.rb
index c9e4e4863..07b246424 100644
--- a/test/unit/lib/redmine/export/pdf/issues_pdf_test.rb
+++ b/test/unit/lib/redmine/export/pdf/issues_pdf_test.rb
@@ -36,4 +36,15 @@ class IssuesPdfHelperTest < ActiveSupport::TestCase
     results = fetch_row_values(issue, query, 0)
     assert_equal ["2", "Add ingredients categories", "4.34"], results
   end
+
+  def test_fetch_row_values_should_be_able_to_handle_parent_issue_subject
+    query = IssueQuery.new(:project => Project.find(1), :name => '_')
+    query.column_names = [:subject, 'parent.subject']
+    issue = Issue.find(2)
+    issue.parent = Issue.find(1)
+    issue.save!
+
+    results = fetch_row_values(issue, query, 0)
+    assert_equal ['2', 'Add ingredients categories', 'Cannot print recipes'], results
+  end
 end