From: Nick Burch <nick@apache.org>
Date: Thu, 23 Apr 2015 18:20:27 +0000 (+0000)
Subject: Make the test generic across POIFS and NPOIFS
X-Git-Tag: REL_3_12_FINAL~41
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=158a02f14431265f0642aa3b1c886d6389e59b07;p=poi.git

Make the test generic across POIFS and NPOIFS

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1675698 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/src/testcases/org/apache/poi/poifs/filesystem/TestFileSystemBugs.java b/src/testcases/org/apache/poi/poifs/filesystem/TestFileSystemBugs.java
index cdd70c33ad..c5fe52f819 100644
--- a/src/testcases/org/apache/poi/poifs/filesystem/TestFileSystemBugs.java
+++ b/src/testcases/org/apache/poi/poifs/filesystem/TestFileSystemBugs.java
@@ -34,33 +34,45 @@ public final class TestFileSystemBugs extends TestCase {
     public void testNotesOLE2Files() throws Exception {
         POIDataSamples _samples = POIDataSamples.getPOIFSInstance();
 
-        // Open the file up
-        POIFSFileSystem fs = new POIFSFileSystem(
-                _samples.openResourceAsStream("Notes.ole2")
-                );
+        // Open the file up with the two FileSystems
+        @SuppressWarnings("resource")
+        DirectoryNode[] roots = new DirectoryNode[] {
+                new POIFSFileSystem(
+                        _samples.openResourceAsStream("Notes.ole2")
+                ).getRoot(),
+                new NPOIFSFileSystem(
+                        _samples.openResourceAsStream("Notes.ole2")
+                ).getRoot()
+        };
 
         // Check the contents
-        assertEquals(1, fs.getRoot().getEntryCount());
+        for (DirectoryNode root : roots) {
+            assertEquals(1, root.getEntryCount());
 
-        Entry entry = fs.getRoot().getEntries().next();
-        assertTrue(entry.isDirectoryEntry());
-        assertTrue(entry instanceof DirectoryEntry);
+            Entry entry = root.getEntries().next();
+            assertTrue(entry.isDirectoryEntry());
+            assertTrue(entry instanceof DirectoryEntry);
 
-        // The directory lacks a name!
-        DirectoryEntry dir = (DirectoryEntry)entry;
-        assertEquals("", dir.getName());
+            // The directory lacks a name!
+            DirectoryEntry dir = (DirectoryEntry)entry;
+            assertEquals("", dir.getName());
 
-        // Has two children
-        assertEquals(2, dir.getEntryCount());
+            // Has two children
+            assertEquals(2, dir.getEntryCount());
 
-        // Check them
-        Iterator<Entry> it = dir.getEntries();
-        entry = it.next();
-        assertEquals(true, entry.isDocumentEntry());
-        assertEquals("\u0001Ole10Native", entry.getName());
+            // Check them
+            Iterator<Entry> it = dir.getEntries();
+            entry = it.next();
+            assertEquals(true, entry.isDocumentEntry());
+            assertEquals("\u0001Ole10Native", entry.getName());
 
-        entry = it.next();
-        assertEquals(true, entry.isDocumentEntry());
-        assertEquals("\u0001CompObj", entry.getName());
+            entry = it.next();
+            assertEquals(true, entry.isDocumentEntry());
+            assertEquals("\u0001CompObj", entry.getName());
+            
+            // Tidy
+            if (root.getNFileSystem() != null)
+                root.getNFileSystem().close();
+        }
     }
 }