From: Nick Burch Date: Wed, 30 Apr 2008 11:10:49 +0000 (+0000) Subject: Tests to show that bugs 44891 and 44861 were both already fixed X-Git-Tag: REL_3_2_FINAL~377 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=15e082cd9bae4b71fc5a0705b2c58f6204305602;p=poi.git Tests to show that bugs 44891 and 44861 were both already fixed git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@652329 13f79535-47bb-0310-9956-ffa450edef68 --- diff --git a/src/testcases/org/apache/poi/hssf/data/44840.xls b/src/testcases/org/apache/poi/hssf/data/44840.xls new file mode 100644 index 0000000000..66dd9185ea Binary files /dev/null and b/src/testcases/org/apache/poi/hssf/data/44840.xls differ diff --git a/src/testcases/org/apache/poi/hssf/data/44861.xls b/src/testcases/org/apache/poi/hssf/data/44861.xls new file mode 100644 index 0000000000..bab82b3135 Binary files /dev/null and b/src/testcases/org/apache/poi/hssf/data/44861.xls differ diff --git a/src/testcases/org/apache/poi/hssf/data/44891.xls b/src/testcases/org/apache/poi/hssf/data/44891.xls new file mode 100644 index 0000000000..30082aa8ff Binary files /dev/null and b/src/testcases/org/apache/poi/hssf/data/44891.xls differ diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java b/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java index 7e9aeff5f7..4ba81c4098 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java @@ -882,10 +882,20 @@ public final class TestBugs extends TestCase { * Bug 28774: Excel will crash when opening xls-files with images. */ public void test28774() { - HSSFWorkbook wb = openSample("28774.xls"); assertTrue("no errors reading sample xls", true); writeOutAndReadBack(wb); assertTrue("no errors writing sample xls", true); } + + /** + * Had a problem apparently, not sure what as it + * works just fine... + */ + public void test44891() throws Exception { + HSSFWorkbook wb = openSample("44891.xls"); + assertTrue("no errors reading sample xls", true); + writeOutAndReadBack(wb); + assertTrue("no errors writing sample xls", true); + } } diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorBugs.java b/src/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorBugs.java index 19069d32b2..0ef6429173 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorBugs.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorBugs.java @@ -19,6 +19,7 @@ package org.apache.poi.hssf.usermodel; import java.io.File; import java.io.FileOutputStream; +import java.util.Iterator; import java.util.List; import junit.framework.TestCase; @@ -252,4 +253,29 @@ public final class TestFormulaEvaluatorBugs extends TestCase { } assertEquals(true, cell.getBooleanCellValue()); } -} + + public void testClassCast_bug44861() throws Exception { + HSSFWorkbook wb = HSSFTestDataSamples. + openSampleWorkbook("44861.xls"); + + // Check direct + HSSFFormulaEvaluator.evaluateAllFormulaCells(wb); + + // And via calls + int numSheets = wb.getNumberOfSheets(); + for(int i=0; i