From: Wouter Admiraal <wouter.admiraal@sonarsource.com>
Date: Thu, 20 Jun 2019 13:32:16 +0000 (+0200)
Subject: SONAR-11688 Make Help menu accessible
X-Git-Tag: 8.0~516
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=167354eaadd73a88892299adb7fe22b7deb165e2;p=sonarqube.git

SONAR-11688 Make Help menu accessible
---

diff --git a/server/sonar-web/src/main/js/app/components/embed-docs-modal/EmbedDocsPopupHelper.tsx b/server/sonar-web/src/main/js/app/components/embed-docs-modal/EmbedDocsPopupHelper.tsx
index 6334e7b4922..be13e9494ef 100644
--- a/server/sonar-web/src/main/js/app/components/embed-docs-modal/EmbedDocsPopupHelper.tsx
+++ b/server/sonar-web/src/main/js/app/components/embed-docs-modal/EmbedDocsPopupHelper.tsx
@@ -18,6 +18,7 @@
  * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  */
 import * as React from 'react';
+import { ButtonLink } from '../../../components/ui/buttons';
 import Toggler from '../../../components/controls/Toggler';
 import HelpIcon from '../../../components/icons-components/HelpIcon';
 import { lazyLoad } from '../../../components/lazyLoad';
@@ -55,9 +56,7 @@ export default class EmbedDocsPopupHelper extends React.PureComponent<{}, State>
     this.setState({ helpOpen });
   };
 
-  handleClick = (event: React.MouseEvent<HTMLAnchorElement>) => {
-    event.preventDefault();
-    event.currentTarget.blur();
+  handleClick = () => {
     this.toggleHelp();
   };
 
@@ -78,13 +77,14 @@ export default class EmbedDocsPopupHelper extends React.PureComponent<{}, State>
           onRequestClose={this.closeHelp}
           open={this.state.helpOpen}
           overlay={<EmbedDocsPopup onClose={this.closeHelp} />}>
-          <a
+          <ButtonLink
+            aria-expanded={this.state.helpOpen}
+            aria-haspopup={true}
             className="navbar-help navbar-icon"
-            href="#"
             onClick={this.handleClick}
             title={translate('help')}>
             <HelpIcon />
-          </a>
+          </ButtonLink>
         </Toggler>
       </li>
     );