From: Carl Schwan <carl@carlschwan.eu>
Date: Tue, 19 Apr 2022 08:56:54 +0000 (+0200)
Subject: Fix Call to a member function getSize() on bool
X-Git-Tag: v25.0.0beta1~430^2
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=1c97611fa245c9dc710e768015f1021a440eb833;p=nextcloud-server.git

Fix Call to a member function getSize() on bool

getFileInfo might return false, handle this case by ignoring the result

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
---

diff --git a/lib/private/legacy/OC_Files.php b/lib/private/legacy/OC_Files.php
index 41ac20577b2..02e15fd08d5 100644
--- a/lib/private/legacy/OC_Files.php
+++ b/lib/private/legacy/OC_Files.php
@@ -145,21 +145,26 @@ class OC_Files {
 			}
 
 			self::lockFiles($view, $dir, $files);
+			$numberOfFiles = 0;
+			$fileSize = 0;
 
 			/* Calculate filesize and number of files */
 			if ($getType === self::ZIP_FILES) {
 				$fileInfos = [];
-				$fileSize = 0;
 				foreach ($files as $file) {
 					$fileInfo = \OC\Files\Filesystem::getFileInfo($dir . '/' . $file);
-					$fileSize += $fileInfo->getSize();
-					$fileInfos[] = $fileInfo;
+					if ($fileInfo) {
+						$fileSize += $fileInfo->getSize();
+						$fileInfos[] = $fileInfo;
+					}
 				}
 				$numberOfFiles = self::getNumberOfFiles($fileInfos);
 			} elseif ($getType === self::ZIP_DIR) {
 				$fileInfo = \OC\Files\Filesystem::getFileInfo($dir . '/' . $files);
-				$fileSize = $fileInfo->getSize();
-				$numberOfFiles = self::getNumberOfFiles([$fileInfo]);
+				if ($fileInfo) {
+					$fileSize = $fileInfo->getSize();
+					$numberOfFiles = self::getNumberOfFiles([$fileInfo]);
+				}
 			}
 
 			$streamer = new Streamer(\OC::$server->getRequest(), $fileSize, $numberOfFiles);