From: Yegor Kozlov <yegor@apache.org>
Date: Wed, 10 Oct 2012 11:09:48 +0000 (+0000)
Subject: Bugzilla >53974 - Avoid exception when constructing HSSFWorbook on Google App Engine
X-Git-Tag: 3.10-beta1~128
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=1e41416423e00d07de5fc72ae64681ab8f09efa1;p=poi.git

Bugzilla >53974 - Avoid exception when constructing HSSFWorbook on Google App Engine

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1396543 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/src/documentation/content/xdocs/status.xml b/src/documentation/content/xdocs/status.xml
index 139ea60030..1180c5cdfc 100644
--- a/src/documentation/content/xdocs/status.xml
+++ b/src/documentation/content/xdocs/status.xml
@@ -34,6 +34,7 @@
 
     <changes>
         <release version="3.9-beta1" date="2012-??-??">
+          <action dev="poi-developers" type="fix">53974 - Avoid NPE when constructing HSSFWorbook on Google App Engine</action>
           <action dev="poi-developers" type="fix">53568 - Fixed null returned by XSSFPicture.getPictureData()</action>
           <action dev="poi-developers" type="fix">53950 - fixed setForceFormulaRecalculation to reset workbook-level "manual" flag</action>
           <action dev="poi-developers" type="fix">52211 - avoid unnessary re-coverting content types to US-ASCII, it can cause exceptions on ibm mainframes</action>
diff --git a/src/java/org/apache/poi/hssf/model/InternalWorkbook.java b/src/java/org/apache/poi/hssf/model/InternalWorkbook.java
index 3f421d99b6..7161e48f14 100644
--- a/src/java/org/apache/poi/hssf/model/InternalWorkbook.java
+++ b/src/java/org/apache/poi/hssf/model/InternalWorkbook.java
@@ -1094,12 +1094,17 @@ public final class InternalWorkbook {
     private static WriteAccessRecord createWriteAccess() {
         WriteAccessRecord retval = new WriteAccessRecord();
 
+        String defaultUserName = "POI";
         try {
-            retval.setUsername(System.getProperty("user.name"));
+            String username = System.getProperty("user.name");
+            // Google App engine returns null for user.name, see Bug 53974
+            if(username == null) username = defaultUserName;
+
+            retval.setUsername(username);
         } catch (AccessControlException e) {
                 // AccessControlException can occur in a restricted context
                 // (client applet/jws application or restricted security server)
-                retval.setUsername("POI");
+                retval.setUsername(defaultUserName);
         }
         return retval;
     }