From: Rick Waldron Date: Tue, 16 Oct 2012 19:01:59 +0000 (-0400) Subject: Replace unknown, mysterious html arg to replaceWith(fn...), with just the current... X-Git-Tag: 1.9.0b1~192^2~2 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=1fdc0b7f7873885aebe279af9ffccb3900d804b2;p=jquery.git Replace unknown, mysterious html arg to replaceWith(fn...), with just the current node. --- diff --git a/src/manipulation.js b/src/manipulation.js index aced4567b..5734b33d9 100644 --- a/src/manipulation.js +++ b/src/manipulation.js @@ -263,9 +263,12 @@ jQuery.fn.extend({ // Make sure that the elements are removed from the DOM before they are inserted // this can help fix replacing a parent with child elements if ( jQuery.isFunction( value ) ) { - return this.each(function(i) { - var self = jQuery(this), old = self.html(); - self.replaceWith( value.call( this, i, old ) ); + return this.each(function( index ) { + // HTML argument replaced by "this" element + // 1. There were no supporting tests + // 2. There was no internal code relying on this + // 3. There was no documentation of an html argument + jQuery( this ).replaceWith( value.call( this, index, this ) ); }); }