From: gnarf <gnarf@gnarf.net>
Date: Sun, 6 Mar 2011 11:22:32 +0000 (-0600)
Subject: effects.clip: Style Guidance
X-Git-Tag: 1.9m5~235^2~20
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=210fcc427819140795e71392d07bbdd836eee2bb;p=jquery-ui.git

effects.clip: Style Guidance
---

diff --git a/ui/jquery.effects.clip.js b/ui/jquery.effects.clip.js
index 9c29d252d..643e436b1 100644
--- a/ui/jquery.effects.clip.js
+++ b/ui/jquery.effects.clip.js
@@ -12,39 +12,55 @@
  */
 (function( $, undefined ) {
 
-$.effects.clip = function(o) {
+$.effects.clip = function( o ) {
 
-	return this.queue(function() {
+	return this.queue( function() {
 
 		// Create element
 		var el = $( this ), 
 			props = ['position','top','bottom','left','right','height','width'], 
 			mode = $.effects.setMode( el, o.mode || 'hide' ),
-			direction = o.direction || 'vertical'; // Default direction
-
-		// Adjust
-		$.effects.save(el, props); el.show(); // Save & Show
-		var wrapper = $.effects.createWrapper(el).css({overflow:'hidden'}); // Create Wrapper
-		var animate = el[0].tagName == 'IMG' ? wrapper : el;
-		var ref = {
-			size: (direction == 'vertical') ? 'height' : 'width',
-			position: (direction == 'vertical') ? 'top' : 'left'
-		};
-		var distance = (direction == 'vertical') ? animate.height() : animate.width();
-		if(mode == 'show') { animate.css(ref.size, 0); animate.css(ref.position, distance / 2); } // Shift
-
-		// Animation
-		var animation = {};
-		animation[ref.size] = mode == 'show' ? distance : 0;
-		animation[ref.position] = mode == 'show' ? 0 : distance / 2;
+			direction = o.direction || 'vertical',
+			ref = {
+				size: (direction == 'vertical') ? 'height' : 'width',
+				position: (direction == 'vertical') ? 'top' : 'left'
+			},
+			animation = {},
+			wrapper, animate, distance;
+
+		// Save & Show
+		$.effects.save( el, props ); el.show(); 
+
+		// Create Wrapper
+		wrapper = $.effects.createWrapper( el ).css({ 
+			overflow: 'hidden' 
+		});
+		animate = ( el[0].tagName == 'IMG' ) ? wrapper : el;
+		distance = ( direction == 'vertical' ) ? animate.height() : animate.width();
+
+		// Shift
+		if ( mode == 'show' ) {
+			animate.css( ref.size, 0 );
+			animate.css( ref.position, distance / 2 );
+		}
+
+		// Create Animation Object:
+		animation[ ref.size ] = mode == 'show' ? distance : 0;
+		animation[ ref.position ] = mode == 'show' ? 0 : distance / 2;
 
 		// Animate
-		animate.animate(animation, { queue: false, duration: o.duration, easing: o.easing, complete: function() {
-			if(mode == 'hide') el.hide(); // Hide
-			$.effects.restore(el, props); $.effects.removeWrapper(el); // Restore
-			if(o.complete) o.complete.apply(el[0], arguments); // Callback
-			el.dequeue();
-		}});
+		animate.animate( animation, { 
+			queue: false, 
+			duration: o.duration, 
+			easing: o.easing, 
+			complete: function() {
+				mode == 'hide' && el.hide(); 
+				$.effects.restore( el, props ); 
+				$.effects.removeWrapper( el ); 
+				$.isFunction( o.complete ) && o.complete.apply( el[ 0 ], arguments );
+				el.dequeue();
+			}
+		});
 
 	});