From: Vsevolod Stakhov <vsevolod@highsecure.ru>
Date: Tue, 7 Jul 2015 07:06:23 +0000 (+0100)
Subject: Slightly improve variables extraction code.
X-Git-Tag: 1.0.0~434
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=23ab4cf76ef156db35dfaae704966fd0963c12d6;p=rspamd.git

Slightly improve variables extraction code.
---

diff --git a/src/main.c b/src/main.c
index b6649234f..dfd6182d8 100644
--- a/src/main.c
+++ b/src/main.c
@@ -1075,13 +1075,13 @@ main (gint argc, gchar **argv, gchar **env)
 	if (argc > 0) {
 		/* Parse variables */
 		for (i = 0; i < argc; i ++) {
-			/* XXX: inefficient, but executed merely once */
 			if (strchr (argv[i], '=') != NULL) {
-				gchar *k, *v;
+				gchar *k, *v, *t;
 
 				k = g_strdup (argv[i]);
-				v = g_strdup (strchr (k, '=') + 1);
-				*(strchr (k, '=')) = '\0';
+				t = strchr (k, '=');
+				v = g_strdup (t + 1);
+				*t = '\0';
 
 				if (vars == NULL) {
 					vars = g_hash_table_new_full (rspamd_strcase_hash,