From: Andreas Beeker <kiwiwings@apache.org>
Date: Sun, 19 Jun 2016 01:06:55 +0000 (+0000)
Subject: findbugs fixes - ME_MUTABLE_ENUM_FIELD
X-Git-Tag: REL_3_15_BETA2~58
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=23baf09e91969ec1298c7875341615792c930ddf;p=poi.git

findbugs fixes - ME_MUTABLE_ENUM_FIELD

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749116 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/src/java/org/apache/poi/sl/usermodel/PresetColor.java b/src/java/org/apache/poi/sl/usermodel/PresetColor.java
index 72e9fc661f..f78dbca406 100644
--- a/src/java/org/apache/poi/sl/usermodel/PresetColor.java
+++ b/src/java/org/apache/poi/sl/usermodel/PresetColor.java
@@ -247,9 +247,9 @@ public enum PresetColor {
     MenuHighlight           (0xff3399ff, 174, "menuHighlight")
     ;
 
-    public Color color;
-    public int nativeId;
-    public String ooxmlId;
+    public final Color color;
+    public final int nativeId;
+    public final String ooxmlId;
 
     PresetColor(Integer rgb, int nativeId, String ooxmlId) {
         this.color = (rgb == null) ? null : new Color(rgb, true);
diff --git a/src/java/org/apache/poi/ss/usermodel/ConditionalFormattingThreshold.java b/src/java/org/apache/poi/ss/usermodel/ConditionalFormattingThreshold.java
index 8f2ecaf526..a5e52b1b3a 100644
--- a/src/java/org/apache/poi/ss/usermodel/ConditionalFormattingThreshold.java
+++ b/src/java/org/apache/poi/ss/usermodel/ConditionalFormattingThreshold.java
@@ -43,7 +43,7 @@ public interface ConditionalFormattingThreshold {
         FORMULA(7, "formula");
         
         /** Numeric ID of the type */
-        public int id;
+        public final int id;
         /** Name (system) of the type */
         public final String name;
         
diff --git a/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfFill.java b/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfFill.java
index 2dabb069fd..e13164f348 100644
--- a/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfFill.java
+++ b/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfFill.java
@@ -57,7 +57,7 @@ public class HwmfFill {
         ;
 
 
-        int flag;
+        public final int flag;
         ColorUsage(int flag) {
             this.flag = flag;
         }
@@ -208,8 +208,8 @@ public class HwmfFill {
              */
             WINDING(0x0002, Path2D.WIND_NON_ZERO);
 
-            public int wmfFlag;
-            public int awtFlag;
+            public final int wmfFlag;
+            public final int awtFlag;
             HwmfPolyfillMode(int wmfFlag, int awtFlag) {
                 this.wmfFlag = wmfFlag;
                 this.awtFlag = awtFlag;
diff --git a/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfPenStyle.java b/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfPenStyle.java
index fb2ce122e1..a881c44035 100644
--- a/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfPenStyle.java
+++ b/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfPenStyle.java
@@ -41,8 +41,8 @@ public class HwmfPenStyle implements Cloneable {
         /** Line ends at end point*/
         FLAT(2, BasicStroke.CAP_BUTT);        
 
-        public int wmfFlag;
-        public int awtFlag;
+        public final int wmfFlag;
+        public final int awtFlag;
         HwmfLineCap(int wmfFlag, int awtFlag) {
             this.wmfFlag = wmfFlag;
             this.awtFlag = awtFlag;
@@ -67,8 +67,8 @@ public class HwmfPenStyle implements Cloneable {
          */
         MITER(2, BasicStroke.JOIN_MITER);
 
-        public int wmfFlag;
-        public int awtFlag;
+        public final int wmfFlag;
+        public final int awtFlag;
         HwmfLineJoin(int wmfFlag, int awtFlag) {
             this.wmfFlag = wmfFlag;
             this.awtFlag = awtFlag;
@@ -121,8 +121,8 @@ public class HwmfPenStyle implements Cloneable {
         USERSTYLE(0x0007, null);
         
 
-        public int wmfFlag;
-        public float[] dashes;
+        public final int wmfFlag;
+        public final float[] dashes;
         HwmfLineDash(int wmfFlag, float... dashes) {
             this.wmfFlag = wmfFlag;
             this.dashes = dashes;
diff --git a/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfRecordType.java b/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfRecordType.java
index db40bb6f8c..edc2e6f4d8 100644
--- a/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfRecordType.java
+++ b/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfRecordType.java
@@ -95,8 +95,8 @@ public enum HwmfRecordType {
     ,textOut(0x0521, HwmfText.WmfTextOut.class)
     ;
     
-    public int id;
-    public Class<? extends HwmfRecord> clazz;
+    public final int id;
+    public final Class<? extends HwmfRecord> clazz;
     
     HwmfRecordType(int id, Class<? extends HwmfRecord> clazz) {
         this.id = id;