From: James Moger <james.moger@gitblit.com>
Date: Fri, 18 Apr 2014 00:31:41 +0000 (-0400)
Subject: [findbugs] Fix missing 'throw' on plugin installation failure
X-Git-Tag: v1.5.0~30
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=23d0e14babe89fff39e377c8ea7295837b07a343;p=gitblit.git

[findbugs] Fix missing 'throw' on plugin installation failure
---

diff --git a/src/main/java/com/gitblit/transport/ssh/commands/PluginDispatcher.java b/src/main/java/com/gitblit/transport/ssh/commands/PluginDispatcher.java
index 62b13576..6f8f95ae 100644
--- a/src/main/java/com/gitblit/transport/ssh/commands/PluginDispatcher.java
+++ b/src/main/java/com/gitblit/transport/ssh/commands/PluginDispatcher.java
@@ -518,7 +518,7 @@ public class PluginDispatcher extends DispatchCommand {
 					if (gitblit.installPlugin(urlOrId, !disableChecksum)) {
 						stdout.println(String.format("Installed %s", urlOrId));
 					} else {
-						new UnloggedFailure(1, String.format("Failed to install %s", urlOrId));
+						throw new UnloggedFailure(1, String.format("Failed to install %s", urlOrId));
 					}
 				} else {
 					PluginRelease pr = gitblit.lookupRelease(urlOrId, version);